Re: [comdlg32] Remove unused variable (Coverity)

[Paul Vriens]

On 11/12/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> Hi,
>
> hResource16 is not used.
>
> Will fix Coverity-17.
>
> Changelog
>   Remove unused variable
>
> Cheers,
>
> Paul.
> ---
> dlls/comdlg32/fontdlg16.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/comdlg32/fontdlg16.c b/dlls/comdlg32/fontdlg16.c
> index 4b13c2d..c5f11df 100644
> --- a/dlls/comdlg32/fontdlg16.c
> +++ b/dlls/comdlg32/fontdlg16.c
> @@ -164,7 +164,7 @@ INT16 WINAPI FontStyleEnumProc16( SEGPTR
> BOOL16 WINAPI ChooseFont16(LPCHOOSEFONT16 lpChFont)
> {
>      HINSTANCE16 hInst;
> -    HANDLE16 hDlgTmpl16 = 0, hResource16 = 0;
> +    HANDLE16 hDlgTmpl16 = 0;
>      HGLOBAL16 hGlobal16 = 0;
>      BOOL16 bRet = FALSE;
>      LPVOID template;
> @@ -255,7 +255,6 @@ BOOL16 WINAPI ChooseFont16(LPCHOOSEFONT1
>      hInst = GetWindowLongPtrA(HWND_32(lpChFont->hwndOwner),
> GWLP_HINSTANCE);
>      bRet = DialogBoxIndirectParam16(hInst, hDlgTmpl16,
> lpChFont->hwndOwner,
>                       (DLGPROC16) ptr, (DWORD)lpChFont);
> -    if (hResource16) FreeResource16(hDlgTmpl16);
>      if (hGlobal16)
>      {
>          GlobalUnlock16(hGlobal16);
> --
> 1.4.3.5

Forget this one as I'm not sure whether hDlgTmpl16 needs to be freed.

Cheers,

Paul.