Re: [PATCH 4/4] dmloader/tests: Add some IDirectMusicLoader directory tests.

[Sebastian Lackner]

On 27.04.2017 19:15, Michael Stefaniuc wrote:
> Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>
> ---
>  dlls/dmloader/tests/loader.c | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)

Your patch introduced a bunch of test failures here:

loader.c:69: Test succeeded inside todo block: SetSearchDirectory failed with 0
loader.c:71: Test failed: Second SetSearchDirectory failed with 0
loader.c:73: Test failed: SetSearchDirectory failed with 0x1

[PATCH 4/4] dmloader/tests: Add some IDirectMusicLoader directory tests.

[Michael Stefaniuc]

On 04/28/2017 02:57 PM, Sebastian Lackner wrote:
> On 27.04.2017 19:15, Michael Stefaniuc wrote:
> > Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>
> > ---
> >  dlls/dmloader/tests/loader.c | 41 +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
>
> Your patch introduced a bunch of test failures here:
>
> loader.c:69: Test succeeded inside todo block: SetSearchDirectory failed with 0
> loader.c:71: Test failed: Second SetSearchDirectory failed with 0
> loader.c:73: Test failed: SetSearchDirectory failed with 0x1
> Yeah, IDirectMusicLoader_SetSearchDirectory() in Wine seems very
> "finicky". And I wanted to avoid looking more at it but meh...

bye
	michael