Re: [PATCH] bcrypt: Add stub for BCryptOpenAlgorithmProvider.

[Dmitry Timoshkov]

Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> +@ stdcall BCryptOpenAlgorithmProvider(ptr ptr ptr long)

It should be (ptr wstr wstr long)
> +NTSTATUS WINAPI BCryptOpenAlgorithmProvider(BCRYPT_ALG_HANDLE *phAlgorithm, LPCWSTR pszAlgId,
> +                                            LPCWSTR pszImplementation, DWORD dwFlags)
> +{
> +    FIXME("%p, %s, %s, %08x - stub\n", phAlgorithm, wine_dbgstr_w(pszAlgId), wine_dbgstr_w(pszImplementation), dwFlags);
> +
> +    *phAlgorithm = NULL;
> +
> +    return STATUS_NOT_IMPLEMENTED;
> +}

Probably there should be a test for NULL before writing to *phAlgorithm.

Also please avoid using hungarian notation for variable naming in Wine.

-- 
Dmitry.