Re: d3d9: Remove WINAPI on static functions where not needed.

[Vitaliy Margolen]

Francois Gouget wrote:
> ---
>
> If you know other places where the functions touched by this patch 
> are used, please let me know. For more details, see:
>
> /* This isn't in MSDN!
> -static HRESULT  WINAPI  IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) {
> +static HRESULT IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) {
>      IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface;
>      FIXME("(%p) : stub\n", This);
>      return D3D_OK;

You can't do that. It's part of the v-table so it can be called by user
application.

Vitaliy

d3d9: Remove WINAPI on static functions where not needed.

[Henri Verbeet]

2008/11/24 Vitaliy Margolen <wine-devel(a)kievinfo.com>:
> > /* This isn't in MSDN!
> > -static HRESULT  WINAPI  IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) {
> > +static HRESULT IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) {
> >      IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface;
> >      FIXME("(%p) : stub\n", This);
> >      return D3D_OK;
>
> You can't do that. It's part of the v-table so it can be called by user
> application.

Actually, that code is commented out, it should be removed completely.

d3d9: Remove WINAPI on static functions where not needed.

[Francois Gouget]

Henri Verbeet wrote:
> 2008/11/24 Vitaliy Margolen <wine-devel(a)kievinfo.com>:
> > > /* This isn't in MSDN!
> > > -static HRESULT  WINAPI  IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) {
> > > +static HRESULT IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) {
> > >      IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface;
> > >      FIXME("(%p) : stub\n", This);
> > >      return D3D_OK;
> > > You can't do that. It's part of the v-table so it can be called by user
> > > application.
>
> Actually, that code is commented out, it should be removed completely.

Works for me. Updating the patch...

Vitaliy probably saw IDirect3DDevice9Impl_GetFrontBufferData() in 
Direct3DDevice9_Vtbl. Similar name but different function.

-- 
Francois Gouget
fgouget(a)codeweavers.com