wininet: Don't discard the extra info part of a URL in InternetOpenUrl.
A fix to winnet/internet.c turned up in 0.9.32 that's supposed to ensure that the "extra info" part of a URL is correctly included. I think there's a problem with the patch. On line 2865 space is allocated for the extra info: if (!(path_extra = HeapAlloc(GetProcessHeap(), 0, size))) Shouldn't this be in units of sizeof(WCHAR)? That is, if (!(path_extra = HeapAlloc(GetProcessHeap(), 0, size*sizeof(WCHAR)))) Ron
I think so... Hans? On 3/7/07, Ron Yorston <rmy(a)tigress.co.uk> wrote:
A fix to winnet/internet.c turned up in 0.9.32 that's supposed to ensure that the "extra info" part of a URL is correctly included. I think there's a problem with the patch. On line 2865 space is allocated for the extra info:
if (!(path_extra = HeapAlloc(GetProcessHeap(), 0, size)))
Shouldn't this be in units of sizeof(WCHAR)? That is,
if (!(path_extra = HeapAlloc(GetProcessHeap(), 0, size*sizeof(WCHAR))))
Ron
participants (2)
-
Lei Zhang -
Ron Yorston