Re: comctl32: treeview: Message sequencing tests

[Marcelo Duarte]

Chris Peterson escreveu:
> This is another patch for my CS130 assignment. It adds message 
> sequencing tests. Other changes include: I updated one of my previous 
> tests which was not testing the implied message; I changed a 
> SendMessageW to SendMessageA call in DoFocusTest to fix a problem on 
> Windows 98 due to a lack of default unicode support. Any 
> comments/suggestions are welcome.
> Thanks!
> -Chris

Hi!
> @@ -166,7 +315,8 @@ static void DoFocusTest(void)
>      assert(hChild2);
>
> ShowWindow(hMainWnd,SW_SHOW);
> -    SendMessageW(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hChild);
> +    /* Using SendMessageA since Win98 doesn't have default unicode support */
> +    SendMessageA(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hChild);

Use SendMessage() instead.
> static void TestGetSetInsertMarkColor(void)
>  {
>      COLORREF crColor = RGB(0,0,0);
> -    SendMessage( hTree, TVM_SETBKCOLOR, 0, crColor );
> -    crColor = (COLORREF)SendMessage( hTree, TVM_GETBKCOLOR, 0, 0 );
> +    SendMessage( hTree, TVM_SETINSERTMARKCOLOR, 0, crColor );
> +    crColor = (COLORREF)SendMessage( hTree, TVM_GETINSERTMARKCOLOR, 0, 0 );
>      ok(crColor == RGB(0,0,0), "Insert mark color reported as 0x%.8x, expected 0x00000000\n", crColor);

comctl32: treeview: Message sequencing tests

[James Hawkins]

On 3/9/07, Marcelo Duarte <marcelotduarte(a)gmail.com> wrote:
> Chris Peterson escreveu:
> > This is another patch for my CS130 assignment. It adds message
> > sequencing tests. Other changes include: I updated one of my previous
> > tests which was not testing the implied message; I changed a
> > SendMessageW to SendMessageA call in DoFocusTest to fix a problem on
> > Windows 98 due to a lack of default unicode support. Any
> > comments/suggestions are welcome.
> > Thanks!
> > -Chris
>
> Hi!
> > @@ -166,7 +315,8 @@ static void DoFocusTest(void)
> >      assert(hChild2);
> >
> > ShowWindow(hMainWnd,SW_SHOW);
> > -    SendMessageW(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hChild);
> > +    /* Using SendMessageA since Win98 doesn't have default unicode support */
> > +    SendMessageA(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)hChild);
>
> Use SendMessage() instead.

There's nothing wrong with using SendMessageA.

-- 
James Hawkins