[PATCH] dwmapi: Fix NULL access in DwmIsCompositionEnabled.

[Myah Caron]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49664
Signed-off-by: Myah Caron <qsniyg(a)protonmail.com>
---
 dlls/dwmapi/dwmapi_main.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dlls/dwmapi/dwmapi_main.c b/dlls/dwmapi/dwmapi_main.c
index 6378a091f0..72ff6df874 100644
--- a/dlls/dwmapi/dwmapi_main.c
+++ b/dlls/dwmapi/dwmapi_main.c
@@ -52,6 +52,10 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv)
 HRESULT WINAPI DwmIsCompositionEnabled(BOOL *enabled)
 {
     static int once;
+
+    if (!enabled)
+        return E_POINTER;
+
     if (!once)
     {
         FIXME("%p\n", enabled);
--
2.27.0

[Zhiyi Zhang]

Hi Myah,

Thanks for the patch. But I am afraid this is incorrect according to tests.
I sent a new one.

Cheers,
Zhiyi

On 8/7/20 10:55 PM, Myah Caron wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49664
> Signed-off-by: Myah Caron <qsniyg(a)protonmail.com>
> ---
>  dlls/dwmapi/dwmapi_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/dlls/dwmapi/dwmapi_main.c b/dlls/dwmapi/dwmapi_main.c
> index 6378a091f0..72ff6df874 100644
> --- a/dlls/dwmapi/dwmapi_main.c
> +++ b/dlls/dwmapi/dwmapi_main.c
> @@ -52,6 +52,10 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv)
>  HRESULT WINAPI DwmIsCompositionEnabled(BOOL *enabled)
>  {
>      static int once;
> +
> +    if (!enabled)
> +        return E_POINTER;
> +
>      if (!once)
>      {
>          FIXME("%p\n", enabled);
> --
> 2.27.0