Re: [PATCH 1/5] wined3d: Also update the container in wined3d_surface_update_desc().
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-22 12:32, schrieb Henri Verbeet:
This fixes a bug exposed by commit 415b8037206b1d4c104d9623037458739f6cfdf5. In particular, wined3d_resource_update_draw_binding() uses the multisample type to determine to appropriate draw binding, and since we never updated that for the container, we could end up with an incorrect draw binding after a device reset. Why not move this call to the texture entirely?
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9yAyAAoJEN0/YqbEcdMwkEsP/juiBeX/o8Pj7hLFs/svF7/U 5fIjBxWSnSq/+WA0/g4OkoIPJoTp+qXjj3irv3r8JCZVTDR455pMDnBZ0yTa+jQa VEF9HvELIurpZz6qOP2UTISD2u2VizzTG74AO8dM+gGYTtX4kPa1+H3QdY7BA2nN XxWW7wGvH5sCzxPh8yx7m8p+vSKzlUQnSuNRoFK+RFLL/VtSeUBsk5OVwuv99LGw lc7DsNH7yKsfG+V5rXyWmgZQsTJDqnlaS+3t5XlqBfdBYuv5JbreUDwdlelbBcmi MWqOdFGVxw60TM7Ra/FXITse9J62lhxjZMyP5nc8nrDp9o6Ci7ynFAzev4FsK6qz eTYj+WRwmsiIKMFPKzx69vz90/ZjdhKM68LPmVythfcB4Cx3YekhME/e7QX0+wZE VBNhZB6VnP7B6BO3tPl8RxMOFzLuFmpgzH2UZevhQVOQximH343CzU0ejf5t0o5Z vkjryDR7QxWE73Ru1p+Sx2b0c81eQtzG+SeDKyjDLLJbVCvFWytj6khUuekupPzF VKHn///AO14pYD1qgRFN4g/FblS792WbXsufV4xDpEsfokoV7E/t8f8vDAoR7FFi rDoP290L95rc9t3ltFW1bVaiKKRrT6mslPZ6e9wR1un7kC9AlfeOiQn8sAVUT3O5 zl9+g1wfTHod4Mi7Sr5J =PO4N -----END PGP SIGNATURE-----
On 22 August 2014 12:49, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Am 2014-08-22 12:32, schrieb Henri Verbeet:
This fixes a bug exposed by commit 415b8037206b1d4c104d9623037458739f6cfdf5. In particular, wined3d_resource_update_draw_binding() uses the multisample type to determine to appropriate draw binding, and since we never updated that for the container, we could end up with an incorrect draw binding after a device reset. Why not move this call to the texture entirely?
That's the plan, but this is just a regression fix.
participants (2)
-
Henri Verbeet -
Stefan Dösinger