[PATCH v2 3/3] msado15: Improve return when field cannot be found
--- dlls/msado15/recordset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c index b21385bd860..f5d4d578766 100644 --- a/dlls/msado15/recordset.c +++ b/dlls/msado15/recordset.c @@ -631,7 +631,7 @@ static HRESULT map_index( struct fields *fields, VARIANT *index, ULONG *ret ) } } - return E_INVALIDARG; + return MAKE_ADO_HRESULT(adErrItemNotFound); } static HRESULT WINAPI fields_get_Item( Fields *iface, VARIANT index, Field **obj ) -- 2.30.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=87179 Your paranoid android. === debiant2 (32 bit report) === msado15: Unhandled exception: page fault on execute access to 0x00000001 in 32-bit code (0x00000001). === debiant2 (32 bit Chinese:China report) === msado15: Unhandled exception: page fault on execute access to 0x00000001 in 32-bit code (0x00000001). === debiant2 (32 bit WoW report) === msado15: Unhandled exception: page fault on execute access to 0x00000001 in 32-bit code (0x00000001). === debiant2 (64 bit WoW report) === msado15: Unhandled exception: page fault on execute access to 0x00000001 in 32-bit code (0x00000001).
participants (2)
-
Alistair Leslie-Hughes -
Marvin