Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus.
This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere. Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me. So I think that if there's any issue, it's on the winetest.exe side. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
2009/2/23 Francois Gouget <fgouget(a)free.fr>:
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus.
This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere.
Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me.
So I think that if there's any issue, it's on the winetest.exe side.
-- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
Thanks, On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way. I will have a look on the winetest side. Nicolas Le Cam
Nicolas Le Cam wrote:
2009/2/23 Francois Gouget <fgouget(a)free.fr>:
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus.
This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere.
Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me.
So I think that if there's any issue, it's on the winetest.exe side.
-- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
Thanks,
On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way.
I will have a look on the winetest side.
Nicolas Le Cam
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails. Not sure how to approach this. -- Cheers, Paul.
2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>:
Nicolas Le Cam wrote:
2009/2/23 Francois Gouget <fgouget(a)free.fr>:
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus.
This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere.
Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me.
So I think that if there's any issue, it's on the winetest.exe side.
-- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
Thanks,
On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way.
I will have a look on the winetest side.
Nicolas Le Cam
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails.
Not sure how to approach this.
-- Cheers,
Paul.
This shouldn't be the case on my box as gdiplus is not present by default on W2K, and should be manually installed (not available through windows update), or installed by a third party app. My test box is a clean install without any third apps, except PDFCreator to simulate a printer to test this part of the suite. I will check if it has gdiplus bundled in. Nicolas Le Cam
Nicolas Le Cam wrote:
2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>:
Nicolas Le Cam wrote:
2009/2/23 Francois Gouget <fgouget(a)free.fr>:
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus. This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere.
Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me.
So I think that if there's any issue, it's on the winetest.exe side.
-- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
Thanks,
On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way.
I will have a look on the winetest side.
Nicolas Le Cam
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails.
Not sure how to approach this.
-- Cheers,
Paul.
This shouldn't be the case on my box as gdiplus is not present by default on W2K, and should be manually installed (not available through windows update), or installed by a third party app. My test box is a clean install without any third apps, except PDFCreator to simulate a printer to test this part of the suite. I will check if it has gdiplus bundled in.
Nicolas Le Cam
Is .NET installed (any version)? -- Cheers, Paul.
On Mon, Feb 23, 2009 at 6:38 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
Nicolas Le Cam wrote:
2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>:
Nicolas Le Cam wrote:
2009/2/23 Francois Gouget <fgouget(a)free.fr>:
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus. This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere.
Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me.
So I think that if there's any issue, it's on the winetest.exe side.
-- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
Thanks,
On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way.
I will have a look on the winetest side.
Nicolas Le Cam
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails.
Not sure how to approach this.
-- Cheers,
Paul.
This shouldn't be the case on my box as gdiplus is not present by default on W2K, and should be manually installed (not available through windows update), or installed by a third party app. My test box is a clean install without any third apps, except PDFCreator to simulate a printer to test this part of the suite. I will check if it has gdiplus bundled in.
Nicolas Le Cam
Is .NET installed (any version)?
-- Cheers,
Paul.
FWIW, the W2K box I have at work has this same problem. There are several applications installed, including .Net 1.1 and .Net 2.0 Service Pack 1. -- -Austin
2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>:
Nicolas Le Cam wrote:
2009/2/23 Paul Vriens <paul.vriens.wine(a)gmail.com>:
Nicolas Le Cam wrote:
2009/2/23 Francois Gouget <fgouget(a)free.fr>:
On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
This avoid a messagebox in regression tests on systems that don't have GdiPlus.
This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done explicitely so that individual tests would not have to dynamically link everywhere.
Also I tested on a platform that does not have gdiplus, and I did not get a message box. In fact, on that platform, winetest did not extract gdiplus_test.exe, which also seems very wrong to me.
So I think that if there's any issue, it's on the winetest.exe side.
-- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U
Thanks,
On my w2k pro when I launch the winetest obtained from test.winehq.org, I get a MessageBox saying gdiplus is missing, and there's already some tests that load dlls dynamically (advpack, cryptui, fusion) so thought it was the right way.
I will have a look on the winetest side.
Nicolas Le Cam
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails.
Not sure how to approach this.
-- Cheers,
Paul.
This shouldn't be the case on my box as gdiplus is not present by default on W2K, and should be manually installed (not available through windows update), or installed by a third party app. My test box is a clean install without any third apps, except PDFCreator to simulate a printer to test this part of the suite. I will check if it has gdiplus bundled in.
Nicolas Le Cam
Is .NET installed (any version)?
-- Cheers,
Paul.
As you've suspected .Net Framework 1.1 and 2.0 SP1 are installed. If LoadLibraryShim is able to find gdiplus bundled with .NET Framework but LoadLibrary can't as well as linking the library to the test, shouldn't we avoid the use of it in the winetest check ? Tests that depends of a specific version of a .NET Framework dll could then use it inline ?
On Mo, 2009-02-23 at 13:38 +0100, Paul Vriens wrote:
Is .NET installed (any version)?
My w2k test box has the popup about the missing gdiplus and dotnet is installed.
From the dllinfo: gdiplus load error 1359
http://test.winehq.org/data/79cc4163fa4867ce0b28ce83111dc6bc18d3df15/2000_dr... -- By by ... Detlef
On Mon, Feb 23, 2009 at 6:15 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails.
Not sure how to approach this.
Silly question: Could we, if LoadLibraryShim returns a library that isn't in the PATH, add it to the PATH in the environment used to call the test exe? Then we would be able to run tests on some "new" versions of dll's we can't cover currently.
Vincent Povirk wrote:
On Mon, Feb 23, 2009 at 6:15 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
The reason you see this is because next to a normal LoadLibrary we also use the .NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but will trough LoadLibraryShim. As winetest now thinks the library is there it will try to launch "gdiplus_test.exe --list" and that of course fails.
Not sure how to approach this.
Silly question:
Could we, if LoadLibraryShim returns a library that isn't in the PATH, add it to the PATH in the environment used to call the test exe? Then we would be able to run tests on some "new" versions of dll's we can't cover currently.
I've been thinking along those same lines. I don't have much time this week but I'll see what I can do. If somebody wants to beat me to it, be my guest ;) -- Cheers, Paul.
participants (6)
-
Austin English -
Detlef Riekenberg -
Francois Gouget -
Nicolas Le Cam -
Paul Vriens -
Vincent Povirk