Re: user32: Enforce that surfaces are flushed after ReleaseDC.

[Alexandre Julliard]

Sebastian Lackner <sebastian(a)fds-team.de> writes:
> @@ -1116,6 +1116,7 @@ HDC WINAPI GetWindowDC( HWND hwnd )
>   */
>  INT WINAPI ReleaseDC( HWND hwnd, HDC hdc )
>  {
> +    flush_window_surfaces( FALSE );
>      return release_dc( hwnd, hdc, FALSE );
>  }

I don't think we can afford to do that, we'd be flushing constantly.

-- 
Alexandre Julliard
julliard(a)winehq.org

user32: Enforce that surfaces are flushed after ReleaseDC.

[Sebastian Lackner]

On 02.03.2015 13:44, Alexandre Julliard wrote:
> Sebastian Lackner <sebastian(a)fds-team.de> writes:
> > @@ -1116,6 +1116,7 @@ HDC WINAPI GetWindowDC( HWND hwnd )
> >   */
> >  INT WINAPI ReleaseDC( HWND hwnd, HDC hdc )
> >  {
> > +    flush_window_surfaces( FALSE );
> >      return release_dc( hwnd, hdc, FALSE );
> >  }
>
> I don't think we can afford to do that, we'd be flushing constantly.

Do you have a better idea how to solve that? Even the wine code internally relies on that,
see for example dlls/comctl/animate.c:ANIMATE_AnimationThread.

user32: Enforce that surfaces are flushed after ReleaseDC.

[Alexandre Julliard]

Sebastian Lackner <sebastian(a)fds-team.de> writes:
> On 02.03.2015 13:44, Alexandre Julliard wrote:
> > Sebastian Lackner <sebastian(a)fds-team.de> writes:
> > > @@ -1116,6 +1116,7 @@ HDC WINAPI GetWindowDC( HWND hwnd )
> > >   */
> > >  INT WINAPI ReleaseDC( HWND hwnd, HDC hdc )
> > >  {
> > > +    flush_window_surfaces( FALSE );
> > >      return release_dc( hwnd, hdc, FALSE );
> > >  }
> >
> > I don't think we can afford to do that, we'd be flushing constantly.
>
> Do you have a better idea how to solve that? Even the wine code internally relies on that,
> see for example dlls/comctl/animate.c:ANIMATE_AnimationThread.

Probably the main thread should be flushing periodically while waiting.

-- 
Alexandre Julliard
julliard(a)winehq.org