Re: dlls/ole32: Silence a FIXME

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-05-25 um 07:56 schrieb Hugh McMaster:
> This fixme appears on wine init either before console output or
> after it. The fixme text is interrupting the output for Wine's
> CLI-based programs, making the output difficult to read.
> WINEDEBUG=-all is the best way to deal with disturbing debug output.
> Or if you want other fixmes WINEDEBUG=-ole helps for this specific one.

Though in many other places trying to QI an unknown interface is a
WARN, not a FIXME. Which interface(s) are the application(s) / other
libs trying to QI?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVYtuhAAoJEN0/YqbEcdMwaLcP/iP/cWFNiqommeRRFXKpv1GN
gCxfqO3H5H/dWlobvFahZ6caZvRg87tw940dO6l9ch3i29A3ooJR0QNmJefk4WBa
RGCp+g9lDxqIp9KvsnHGeHN4gdNXdIkNDtTusuDi1HC31MW3Wcl9rL3eCwTLeK3O
6QNTmAgUK+ZJM5xvBcTPMEidqgw2+L8SyjRTS3I84NPa5tZhRWV5gwvglBIKlvlk
j2ve5wu7MYMyCU0yadmDyCioLeVzMMvIK1vFTkMbLlWlQc+ni2wgAvjD51ODW9Mg
LiJJow6CVnyIF2htAaqs1bVWgtRYiFkHecidliJzqlP3CS11dmys0izy4GCO5nCZ
8vQpvVjHnKjzyrTaHkJJnGXdCSFhcDdjj2VlxrhKZy0C5TUKhsu9HLux3ZZnh8rX
3LX/Di16PgALnx28oAGaA/tkjuutdToZioHVi6V4doRZu1gVQAVdVuqu+jyj8rnR
GQfdUbBsMN0sfdm4wzG2Ls+BdPyymq4FtgvMoYjH7Ue3+4smQu0EilmTCHAnQdZU
OjF4dUgOqSdenQOWbVJGuiQzabwfxfQVePVlUuse7sthnXf8xAk5CCEBl/ITvYxZ
vbORohm8+Xr1yQ9qi7rgRB1ItU3ThrEUFm6DAruIHUtgfiK4zVXczFXh83GXoPur
mY9cApML3tVu3Q0S+WtK
=5NtD
-----END PGP SIGNATURE-----

dlls/ole32: Silence a FIXME

[Hugh McMaster]

On Mon, 25 May 2015 10:21:53 +0200, Stefan Dösinger wrote:
> Am 2015-05-25 um 07:56 schrieb Hugh McMaster:
> > This fixme appears on wine init either before console output or
> > after it. The fixme text is interrupting the output for Wine's
> > CLI-based programs, making the output difficult to read.
> > WINEDEBUG=-all is the best way to deal with disturbing debug output.
> > Or if you want other fixmes WINEDEBUG=-ole helps for this specific one.

Thanks for the tip.
> Though in many other places trying to QI an unknown interface is a
> WARN, not a FIXME. Which interface(s) are the application(s) / other
> libs trying to QI?

The fixme appears every time wine launches an app, so WARN wouldn't help with this issue, although it may be more in keeping with the rest of the codebase.

Searching on iid {00000019-0000-0000-c000-000000000046} brings up an MSDN page an OLE interop, the IExternalConnection Interface.

dlls/ole32: Silence a FIXME

[Nikolay Sivov]

On 25.05.2015 12:44, Hugh McMaster wrote:
> On Mon, 25 May 2015 10:21:53 +0200, Stefan Dösinger wrote:
> > Am 2015-05-25 um 07:56 schrieb Hugh McMaster:
> > > This fixme appears on wine init either before console output or
> > > after it. The fixme text is interrupting the output for Wine's
> > > CLI-based programs, making the output difficult to read.
> > > WINEDEBUG=-all is the best way to deal with disturbing debug output.
> > > Or if you want other fixmes WINEDEBUG=-ole helps for this specific one.
>
> Thanks for the tip.
> > Though in many other places trying to QI an unknown interface is a
> > WARN, not a FIXME. Which interface(s) are the application(s) / other
> > libs trying to QI?
>
> The fixme appears every time wine launches an app, so WARN wouldn't help with this issue, although it may be more in keeping with the rest of the codebase.
>
> Searching on iid {00000019-0000-0000-c000-000000000046} brings up an MSDN page an OLE interop, the IExternalConnection Interface.

It probably comes from explorer, we should silence it there.