Re: winecfg: add all Windows versions and accompanying error message (try 3)

[Andrew Eikum]

On Thu, Apr 09, 2015 at 05:42:36PM -0700, Jason Overland wrote:
> @@ -399,9 +401,49 @@ static void on_remove_app_click(HWND dialog)
>      SendMessageW(GetParent(dialog), PSM_CHANGED, (WPARAM) dialog, 0);
>  }
>
> +static INT_PTR WINAPI win_ver_error_dlg_proc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)

This function should be guarded by an #ifdef. On my 32-bit build, I
get:

appdefaults.c:404:90: warning: ‘win_ver_error_dlg_proc’ defined but not used [-Wunused-function]
> @@ -159,6 +159,22 @@ BEGIN
>      COMBOBOX        IDC_WINVER,100,194,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP    
>  END
>
> +IDD_WINVERERROR DIALOGEX 100, 100, 238, 95
> +STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU
> +CAPTION "Error: Invalid selection"
> +FONT 8, "MS Shell Dlg"
> +BEGIN
> +    LTEXT           "This Wine prefix is built to support 64 bit applications. \
> +                            Because the Windows version you selected does not support 64 bit applications, \
> +                            this prefix cannot be configured to mimic that version of Windows.",
> +                      IDC_STATIC,5,5,220,40
> +    CONTROL         "Please refer to \"How do I create a 32 bit wineprefix on a 64 bit system?\" \
> +                            in the \"Using Wine\" section of the <a href=\"http://wiki.winehq.org/FAQ\">Wine FAQ</a> \
> +                            for instructions on how to create a 32 bit Wine prefix.",
> +                      IDC_WIN_VER_TEXT,"SysLink",0,5,40,220,70

For some reason, this renders without a space between "the" and the
"Wine FAQ" link. Also half of the last 'x' and the period are cut off.

It could be an issue on my system. I'm not very familiar with how RC
files work.

Other than those issues, it seems to work as intended.

Andrew

winecfg: add all Windows versions and accompanying error message (try 3)

[Rosanne DiMesio]

On Fri, 10 Apr 2015 08:04:40 -0500
Andrew Eikum <aeikum(a)codeweavers.com> wrote:
> For some reason, this renders without a space between "the" and the
> "Wine FAQ" link. Also half of the last 'x' and the period are cut off.
>
> It could be an issue on my system. I'm not very familiar with how RC
> files work.

It renders okay on my system. (I do have the MS core fonts installed systemwide; I don't know if that could be a factor.) 

The one thing I would suggest is leaving out the FAQ section names so the message simply reads "Please refer to  the <a href=\"http://wiki.winehq.org/FAQ\">Wine FAQ</a> for instructions on how to create a 32 bit Wine prefix." That way it will still be valid even if the FAQ gets rearranged.

winecfg: add all Windows versions and accompanying error message (try 3)

[Jason Overland]

On 04/10/2015 06:04 AM, Andrew Eikum wrote:
> For some reason, this renders without a space between "the" and the "Wine FAQ" link. Also half of the last 'x' and the period are cut off. It could be an issue on my system. I'm not very familiar with how RC files work. Other than those issues, it seems to work as intended. Andrew

Ah, yes, this was frustrating me as well.  But I think it's unrelated to my patch.  What distro/desktop environment are you using, out of curiosity?  I had the same issue with text getting cut off until I switched from an Ubuntu (Unity) machine to a Lubuntu (LXDE) machine.  I suspect that if you check all the other tabs of winecfg, you'll probably see other text getting cut off (at least I did).  Probably it's some broader issue with fonts/DPI/compositors/spooky action.  I'll add that to the list of things I'd like to investigate if I can ever find the time.