Re: [5/5] D3D9: Add a test for the converted vertex decl

[Ivan Gyurdiev]

Looks good, but this comment is misleading - s/"second"/"first".

+    /* The contents should correspond to the second conversion */
+    VDECL_CHECK(compare_elements(result_decl1, test_elements1));

Also, I thought when Henri was testing this that the object kept changing between sequential Get() calls ?
Did you mention something about a driver bug causing this ?

Ivan

[5/5] D3D9: Add a test for the converted vertex decl

[Stefan Dösinger]

Am Donnerstag 12 April 2007 16:59 schrieb Ivan Gyurdiev:
> Looks good, but this comment is misleading - s/"second"/"first".
>
> +    /* The contents should correspond to the second conversion */
> +    VDECL_CHECK(compare_elements(result_decl1, test_elements1));
>
> Also, I thought when Henri was testing this that the object kept changing
> between sequential Get() calls ? Did you mention something about a driver
> bug causing this ?
> Indeed, the comment is broken copypasting. I'll fix that.

I did not see the declaration change between the GetVertexDeclaration() / 
SetFVF() calls, but I'll readd my temporary check for that(If it is not in 
already).