Currently, there are just eight write-strings violations remaining in the codebase: six in mshtml/nsembed.c (lines 271, 353, 356, 367, 432 and 1237), one in mshtml/nsservice.c (line 454) and one in widl/parser.c (line 848). So I would advocate that the -Wwrite-strings switch could now be turned on. I have just submitted two speculative patches to attempt to fix these remaining warnings, but, if they are wrong, I would be grateful if those of you with mshtml expertise or yacc expertise should kindly step in and finish the respective job properly. Thanks, -- Andy.
On 8/24/06, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote:
Currently, there are just eight write-strings violations remaining in the codebase: six in mshtml/nsembed.c (lines 271, 353, 356, 367, 432 and 1237), one in mshtml/nsservice.c (line 454) and one in widl/parser.c (line 848). So I would advocate that the -Wwrite-strings switch could now be turned on.
Thanks for your work Andy! I agree that we should probably turn the warning on once those remaining warnings are fixed. -- James Hawkins
Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes:
Currently, there are just eight write-strings violations remaining in the codebase: six in mshtml/nsembed.c (lines 271, 353, 356, 367, 432 and 1237), one in mshtml/nsservice.c (line 454) and one in widl/parser.c (line 848). So I would advocate that the -Wwrite-strings switch could now be turned on.
I have just submitted two speculative patches to attempt to fix these remaining warnings, but, if they are wrong, I would be grateful if those of you with mshtml expertise or yacc expertise should kindly step in and finish the respective job properly.
I committed the patches and enabled the warning. Thanks for your work! -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
Andrew Talbot -
James Hawkins