[PATCH 7/9] adsldp: Implement IDirectorySearch::FreeColumn().

[Dmitry Timoshkov]

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru>
---
 dlls/adsldp/adsldp.c     | 9 +++++++--
 dlls/adsldp/tests/ldap.c | 1 -
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/dlls/adsldp/adsldp.c b/dlls/adsldp/adsldp.c
index caa3442099..d9282cf239 100644
--- a/dlls/adsldp/adsldp.c
+++ b/dlls/adsldp/adsldp.c
@@ -1447,8 +1447,13 @@ exit:
 
 static HRESULT WINAPI search_FreeColumn(IDirectorySearch *iface, PADS_SEARCH_COLUMN col)
 {
-    FIXME("%p,%p: stub\n", iface, col);
-    return E_NOTIMPL;
+    TRACE("%p,%p\n", iface, col);
+
+    if (!col) return E_ADS_BAD_PARAMETER;
+
+    heap_free(col->pADsValues);
+
+    return S_OK;
 }
 
 static HRESULT WINAPI search_CloseSearchHandle(IDirectorySearch *iface, ADS_SEARCH_HANDLE res)
diff --git a/dlls/adsldp/tests/ldap.c b/dlls/adsldp/tests/ldap.c
index bd22be8e61..3abbbdadb0 100644
--- a/dlls/adsldp/tests/ldap.c
+++ b/dlls/adsldp/tests/ldap.c
@@ -386,7 +386,6 @@ todo_wine
             }
 
             hr = IDirectorySearch_FreeColumn(ds, &col);
-todo_wine
             ok(hr == S_OK, "got %#x\n", hr);
         }
 
-- 
2.25.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=68444

Your paranoid android.


=== build (build log) ===

error: patch failed: dlls/adsldp/adsldp.c:1338
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/adsldp/adsldp.c:1338
Task: Patch failed to apply

=== debiant (build log) ===

error: patch failed: dlls/adsldp/adsldp.c:1338
Task: Patch failed to apply