Re: [PATCH 4/4] Add a blit method to arbfp_blit.

[Henri Verbeet]

On 1 April 2010 12:50, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote:
> -    if (is_identity_fixup(src_format_desc->color_fixup))
> -    {
> -        TRACE("[OK]\n");
> -        return TRUE;
> -    }
> -
> When did we stop supporting those?
> +    arbfp_blit.set_shader((IWineD3DDevice *)device, src_surface->resource.format_desc,
> +                          src_surface->texture_target, src_surface->pow2Width, src_surface->pow2Height);
> You might as well call arbfp_blit_set() directly.

[PATCH 4/4] Add a blit method to arbfp_blit.

[Roderick Colenbrander]

On Thu, Apr 1, 2010 at 1:45 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
> On 1 April 2010 12:50, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote:
> > -    if (is_identity_fixup(src_format_desc->color_fixup))
> > -    {
> > -        TRACE("[OK]\n");
> > -        return TRUE;
> > -    }
> > -
> > When did we stop supporting those?

My feeling was that we only want to use arbfp_blit for complex fixups
and identity fixups are better suited for fbo_blit/ffp_blit.

Roderick

[PATCH 4/4] Add a blit method to arbfp_blit.

[Henri Verbeet]

On 1 April 2010 14:27, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote:
> My feeling was that we only want to use arbfp_blit for complex fixups
> and identity fixups are better suited for fbo_blit/ffp_blit.

fbo_blit doesn't exist yet here, and may be unavailable depending on
available extensions or ORM used. You pretty much never want to use
ffp_blit if you can help it, due to the huge amount of state
invalidation that does.

Of course arbfp_blit is somewhat broken in the sense that it doesn't
actually create a shader for non-complex fixups and silently lets
ffp_blit handle the blit, but that's something that should be fixed,
not disabled.