[PATCH] ddraw/tests: Destroy viewport in test_lighting_interface_versions() (Valgrind).

[Józef Kucia]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=36381
Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>
---
 dlls/ddraw/tests/ddraw2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c
index 3dda289ad1fc..fced3d943a9a 100644
--- a/dlls/ddraw/tests/ddraw2.c
+++ b/dlls/ddraw/tests/ddraw2.c
@@ -3996,6 +3996,7 @@ static void test_lighting_interface_versions(void)
 
     destroy_material(background);
     destroy_material(emissive);
+    destroy_viewport(device, viewport);
     IDirectDrawSurface_Release(rt);
     IDirect3DDevice2_Release(device);
     ref = IDirectDraw2_Release(ddraw);
-- 
2.19.2

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=47504

Your paranoid android.


=== debian9 (build log) ===

X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  21 (RRSetCrtcConfig)
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  21 (RRSetCrtcConfig)
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  21 (RRSetCrtcConfig)
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  21 (RRSetCrtcConfig)

=== debian9 (build log) ===

X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  21 (RRSetCrtcConfig)
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  140 (RANDR)
  Minor opcode of failed request:  21 (RRSetCrtcConfig)

[Henri Verbeet]

On Tue, 12 Feb 2019 at 13:02, Józef Kucia <jkucia(a)codeweavers.com> wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=36381
> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>
> ---
>  dlls/ddraw/tests/ddraw2.c | 1 +
>  1 file changed, 1 insertion(+)

Wouldn't this apply to the ddraw4.c test as well?