Re: ole32: Add StgCreateFile test and conformance fix
Mike Hearn wrote:
diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c
Fails the test cases on my system after applying ... ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so storage32.c && touch storage32.ok err:storage:validateSTGM unknown flags 00010812 err:storage:validateSTGM unknown flags 00090012 err:storage:validateSTGM unknown flags 00810012 fixme:storage:StgCreateDocfile Transacted mode not implemented. storage32.c:139: Test failed: StgCreateDocfile failed storage32.c:141: Test failed: StgCreateDocfile failed fixme:storage:StgCreateDocfile Transacted mode not implemented. Mike
Those two tests were failing before I wrote the patch - this test suite needs a lot of loving. In particular one of the last tests fails when run against XP ole32 for me. In this case the test I added is on line 178 not 139 or 141. Are you sure you weren't getting these failures before? thanks -mike
Mike Hearn wrote:
Those two tests were failing before I wrote the patch - this test suite needs a lot of loving. In particular one of the last tests fails when run against XP ole32 for me.
In this case the test I added is on line 178 not 139 or 141. Are you sure you weren't getting these failures before?
The existing test suite works fine on Wine for me. Mike
participants (2)
-
Mike Hearn -
Mike McCormack