Re: wine-bugs Digest, Vol 35, Issue 570
On Sun, Jun 29, 2008 at 3:40 AM, <wine-bugs-request(a)winehq.org> wrote:
------------------------------
Message: 8 Date: Sun, 29 Jun 2008 02:53:32 -0500 From: wine-bugs(a)winehq.org Subject: [Bug 9787] Warcraft3 Battle.net Doesn't work (Needs AcceptEx) To: wine-bugs(a)winehq.org Message-ID: <E1KCrj2-0004Ic-W2(a)wine.codeweavers.com> Content-Type: text/plain; charset="UTF-8"
http://bugs.winehq.org/show_bug.cgi?id=9787
Scott Lindeneau <slindeneau(a)gmail.com> changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |slindeneau(a)gmail.com
Raul <rcioldin(a)yahoo.com.br> changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rcioldin(a)yahoo.com.br
--- Comment #206 from Scott Lindeneau <slindeneau(a)gmail.com> 2008-06-21 09:07:50 --- I have been reviewing the patch that Andrey Turkin submitted 2008-01-08 and would like to throw my 2 cents in. I haven't programmed in wine before, but I wouldn't mind starting. Please tell me how/if/why I am wrong.
1) AcceptEx can return synchronously, but it doesn't matter if it does or not. * This means that for simplicity it shouldn't.
2) The AcceptEx call has all of the information it needs when its called. * All of the variables passed to AcceptEx must be initialized before it is called. * The AcceptEx function itself should only be a wrapper for a wine server call to start an async accept, and then it should return.
3) Essentially AcceptEx is an easy way to ask the Operating System to start a thread to listen on a socket, and to get rid of the thread automatically. * We ask the wine server for an async accept (which should just be spawn a thread, listen, and return after connect)
4) AcceptEx only adds the ability to read data on the socket before the socket's error status changes from IO_PENDING to whatever. * Why not add this functionality into the wine server's async accept?
--- Comment #207 from Raul <rcioldin(a)yahoo.com.br> 2008-06-24 13:32:33 --- acceptex unnofficial patch in deb package please!
--- Comment #208 from Austin English <austinenglish(a)gmail.com> 2008-06-24 16:11:23 --- (In reply to comment #207)
acceptex unnofficial patch in deb package please!
Ask the maintainer to do that. Hacks are not accepted in WineHQ's codebase.
You could compile it yourself...
--- Comment #209 from Raul <rcioldin(a)yahoo.com.br> 2008-06-24 17:55:56 --- after a long time downloading and compiling....
the "Disable completion port creation" patch didn't work...
I just have to get in my git dir and do "patch -Np1 < mypatch.diff && tools/make_requests"???
--- Comment #210 from Scott Lindeneau <slindeneau(a)gmail.com> 2008-06-29 02:53:29 --- (In reply to comment #209)
after a long time downloading and compiling....
the "Disable completion port creation" patch didn't work...
I just have to get in my git dir and do "patch -Np1 < mypatch.diff && tools/make_requests"???
then you have to
make depend make sudo make uninstall sudo make install and type your password if prompted for the sudo.
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
Did someone change the bugzilla settings recently? I'm subscribed to wine-bugs in digest mode, but lately (past week or so?), it's been repeating the past few changes of a bug with each new change, so some high traffic bugs are sending 5-6 changes in one 'message'. It's making the bugs harder to read IMHO. Can someone look into this, and re-enable the old behavior? Thanks! Austin
participants (1)
-
Austin English