Re: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> +    if (((ULONG_PTR)Buffer % 8) != 0)
> +        return RPC_X_INVALID_BUFFER;

Shouldn't this be 'if ((ULONG_PTR)Buffer & 7)' instead?

-- 
Dmitry.

rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()

[Nikolay Sivov]

On 03.03.2015 15:38, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > +    if (((ULONG_PTR)Buffer % 8) != 0)
> > +        return RPC_X_INVALID_BUFFER;
> > Shouldn't this be 'if ((ULONG_PTR)Buffer & 7)' instead?

Result would be the same. If you mean that it's faster I have to admit 
that I didn't check if generated code is different.