Re: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()
3 Mar
2015
3 Mar
'15
12:38 p.m.
Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
+ if (((ULONG_PTR)Buffer % 8) != 0) + return RPC_X_INVALID_BUFFER;
Shouldn't this be 'if ((ULONG_PTR)Buffer & 7)' instead? -- Dmitry.
3 Mar
3 Mar
1:03 p.m.
New subject: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()
On 03.03.2015 15:38, Dmitry Timoshkov wrote:
Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
+ if (((ULONG_PTR)Buffer % 8) != 0) + return RPC_X_INVALID_BUFFER; Shouldn't this be 'if ((ULONG_PTR)Buffer & 7)' instead?
Result would be the same. If you mean that it's faster I have to admit that I didn't check if generated code is different.
4027
Age (days ago)
4027
Last active (days ago)
1 comments
2 participants
participants (2)
-
Dmitry Timoshkov -
Nikolay Sivov