Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.
On 11 September 2013 12:09, Jacek Caban <jacek(a)codeweavers.com> wrote:
+typedef enum D3D11_RESOURCE_MISC_FLAG +{ + D3D11_RESOURCE_MISC_GENERATE_MIPS = 0x00000001, + D3D11_RESOURCE_MISC_SHARED = 0x00000002, + D3D11_RESOURCE_MISC_TEXTURECUBE = 0x00000004, + D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS = 0x00000010, + D3D11_RESOURCE_MISC_BUFFER_ALLOW_RAW_VIEWS = 0x00000020, + D3D11_RESOURCE_MISC_BUFFER_STRUCTURED = 0x00000040, + D3D11_RESOURCE_MISC_RESOURCE_CLAMP = 0x00000080, + D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX = 0x00000100, + D3D11_RESOURCE_MISC_GDI_COMPATIBLE = 0x00000200, + D3D11_RESOURCE_MISC_SHARED_NTHANDLE = 0x00000800, + D3D11_RESOURCE_MISC_RESTRICTED_CONTENT = 0x00001000, + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE = 0x00002000, + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE_DRIVER = 0x00004000, + D3D11_RESOURCE_MISC_GUARDED = 0x00008000 +} D3D11_RESOURCE_MISC_FLAG; Arguably those should be __MSABI_LONG, although we may not care enough. We certainly aren't very consistent about it in a lot of other places either.
On 09/11/2013 02:11 PM, Henri Verbeet wrote:
On 11 September 2013 12:09, Jacek Caban <jacek(a)codeweavers.com> wrote:
+typedef enum D3D11_RESOURCE_MISC_FLAG +{ + D3D11_RESOURCE_MISC_GENERATE_MIPS = 0x00000001, + D3D11_RESOURCE_MISC_SHARED = 0x00000002, + D3D11_RESOURCE_MISC_TEXTURECUBE = 0x00000004, + D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS = 0x00000010, + D3D11_RESOURCE_MISC_BUFFER_ALLOW_RAW_VIEWS = 0x00000020, + D3D11_RESOURCE_MISC_BUFFER_STRUCTURED = 0x00000040, + D3D11_RESOURCE_MISC_RESOURCE_CLAMP = 0x00000080, + D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX = 0x00000100, + D3D11_RESOURCE_MISC_GDI_COMPATIBLE = 0x00000200, + D3D11_RESOURCE_MISC_SHARED_NTHANDLE = 0x00000800, + D3D11_RESOURCE_MISC_RESTRICTED_CONTENT = 0x00001000, + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE = 0x00002000, + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE_DRIVER = 0x00004000, + D3D11_RESOURCE_MISC_GUARDED = 0x00008000 +} D3D11_RESOURCE_MISC_FLAG; Arguably those should be __MSABI_LONG, although we may not care enough. We certainly aren't very consistent about it in a lot of other places either. I just replaced the long numeric constants with the __MSABI_LONG. But we don't need those anyway, it's mingw-w64 who needs them for C++ compatibility.
bye michael
On 09/11/13 14:22, Michael Stefaniuc wrote:
On 09/11/2013 02:11 PM, Henri Verbeet wrote:
On 11 September 2013 12:09, Jacek Caban <jacek(a)codeweavers.com> wrote:
+typedef enum D3D11_RESOURCE_MISC_FLAG +{ + D3D11_RESOURCE_MISC_GENERATE_MIPS = 0x00000001, + D3D11_RESOURCE_MISC_SHARED = 0x00000002, + D3D11_RESOURCE_MISC_TEXTURECUBE = 0x00000004, + D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS = 0x00000010, + D3D11_RESOURCE_MISC_BUFFER_ALLOW_RAW_VIEWS = 0x00000020, + D3D11_RESOURCE_MISC_BUFFER_STRUCTURED = 0x00000040, + D3D11_RESOURCE_MISC_RESOURCE_CLAMP = 0x00000080, + D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX = 0x00000100, + D3D11_RESOURCE_MISC_GDI_COMPATIBLE = 0x00000200, + D3D11_RESOURCE_MISC_SHARED_NTHANDLE = 0x00000800, + D3D11_RESOURCE_MISC_RESTRICTED_CONTENT = 0x00001000, + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE = 0x00002000, + D3D11_RESOURCE_MISC_RESTRICT_SHARED_RESOURCE_DRIVER = 0x00004000, + D3D11_RESOURCE_MISC_GUARDED = 0x00008000 +} D3D11_RESOURCE_MISC_FLAG; Arguably those should be __MSABI_LONG, although we may not care enough. We certainly aren't very consistent about it in a lot of other places either. I just replaced the long numeric constants with the __MSABI_LONG. But we don't need those anyway, it's mingw-w64 who needs them for C++ compatibility.
Yes, except we can't do that in IDLs. Looking at this deeper, widl will produce int constant, no matter what suffix I use. I guess I will add L suffix to those IDLs so that once widl propagates type properly, it will deal with __MSABI_LONG. Jacek
participants (3)
-
Henri Verbeet -
Jacek Caban -
Michael Stefaniuc