[PATCH 1/3] ws2_32: WSARecvMsg allows a NULL control buffer when no control messages arrive

[Damjan Jovanovic]

Wine's WSARecvFrom() cannot distinguish between:
1. truncation during conversion of cmsghdrs from *nix to Windows,
which is an error.
2. a NULL WSAMSG.Control.buf passed in by the application, which is valid
   when there is no control data to convert.

Wine always treats it as case (1) and reports an error.

Closes bug 43286.

Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com>
---
 dlls/ws2_32/socket.c     |  8 +++++---
 dlls/ws2_32/tests/sock.c | 17 +++++++++++++++--
 2 files changed, 20 insertions(+), 5 deletions(-)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=54993

Your paranoid android.


=== w7pro64 (64 bit report) ===

ws2_32:
sock.c:11385: Test failed: got 0
sock.c:11386: Test failed: got 0000000000000000
sock.c:11387: Test failed: got 0000
sock.c:11388: Test failed: got 00000000
sock.c:11389: Test failed: got 00000000
sock.c:11396: Test failed: got 0464,00000234,00000002