Re: [PATCH] wined3d: Check pointer before use

[Henri Verbeet]

On 3 August 2016 at 04:29, Alistair Leslie-Hughes
<leslie_alistair(a)hotmail.com> wrote:
> -    if (tq->context->tid != GetCurrentThreadId())
> +    if (!tq->context || tq->context->tid != GetCurrentThreadId())
> How can the context be NULL?

[PATCH] wined3d: Check pointer before use

[Alistair Leslie-Hughes]

On 03/08/16 17:34, Henri Verbeet wrote:
> On 3 August 2016 at 04:29, Alistair Leslie-Hughes
> <leslie_alistair(a)hotmail.com> wrote:
> > -    if (tq->context->tid != GetCurrentThreadId())
> > +    if (!tq->context || tq->context->tid != GetCurrentThreadId())
> > How can the context be NULL?

No sure on the exact cause but running "Need for Speed: The Run"
crashed since the context was NULL.

Best Regards
 Alistair Leslie-Hughes

[PATCH] wined3d: Check pointer before use

[Henri Verbeet]

On 3 August 2016 at 09:43, Alistair Leslie-Hughes
<leslie_alistair(a)hotmail.com> wrote:
> On 03/08/16 17:34, Henri Verbeet wrote:
> > On 3 August 2016 at 04:29, Alistair Leslie-Hughes
> > <leslie_alistair(a)hotmail.com> wrote:
> > > -    if (tq->context->tid != GetCurrentThreadId())
> > > +    if (!tq->context || tq->context->tid != GetCurrentThreadId())
> > > How can the context be NULL?
>
> No sure on the exact cause but running "Need for Speed: The Run"
> crashed since the context was NULL.

Could you create a log with WINEDEBUG="+d3d9,+d3d,+seh,+tid" and
attach it here? Queries that get polled should have been issued
before, and queries that have been issued should have a non-NULL
context.