Re: msvcp90: basic_string_wchar_dtor should return NULL on i386.

[Sebastian Lackner]

On 23.11.2015 13:33, Piotr Caban wrote:
> Probably the commit message would be more readable if it says:
> msvcp90: basic_string_wchar_dtor should set EAX to 0 on i386.

EAX is used to store the return value, so both commit messages are
basically equivalent. If your suggested subject is preferred, I have
no problem when its changed while applying the patch or to resend
later.
> According to my knowledge the application depends on that.
>
> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>

msvcp90: basic_string_wchar_dtor should return NULL on i386.

[Alexandre Julliard]

Sebastian Lackner <sebastian(a)fds-team.de> writes:
> On 23.11.2015 13:33, Piotr Caban wrote:
> > Probably the commit message would be more readable if it says:
> > msvcp90: basic_string_wchar_dtor should set EAX to 0 on i386.
>
> EAX is used to store the return value, so both commit messages are
> basically equivalent. If your suggested subject is preferred, I have
> no problem when its changed while applying the patch or to resend
> later.

A comment explaining why we have a destructor that returns a value would
probably also be a good idea.

-- 
Alexandre Julliard
julliard(a)winehq.org