Re: Call SetLastError() in ParseStringAclToAcl() to correct Conformance Test failure

[James Hawkins]

On Wed, Sep 24, 2008 at 1:19 AM, Paul Bryan Roberts
<pbronline-wine(a)yahoo.co.uk> wrote:
> From 2f6d33f2d66e252bbd6ad3bc0f3e93a1fb780485 Mon Sep 17 00:00:00 2001
> From: Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk>
> Date: Wed, 24 Sep 2008 06:57:33 +0100
> Subject: Call SetLastError() in ParseStringAclToAcl() to correct
> Conformance Test failure
>
> ---
>  dlls/advapi32/security.c       |    7 ++++++-
>  dlls/advapi32/tests/security.c |    1 -
>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
> index ef9ce6e..83bb08e 100644
> --- a/dlls/advapi32/security.c
> +++ b/dlls/advapi32/security.c
> @@ -3735,7 +3735,11 @@ static BOOL ParseStringAclToAcl(LPCWSTR
> StringAcl, LPDWORD lpdwFlags,
>     TRACE("%s\n", debugstr_w(StringAcl));
>
> if (!StringAcl)
> -       return FALSE;
> +    {
> +        SetLastError(ERROR_INVALID_PARAMETER);
> +        TRACE("StringAcl is NULL, returning FALSE\n");
> +        return FALSE;
> +    }

You've added a change (above) that is not verified by a test.  Please
add one before making such a change.  Also, that TRACE is highly
superfluous; please remove it from the patch.

-- 
James Hawkins