Re: ws2_32: Dont tell users to run Wine as root when sockets not creatable
On Saturday 30 June 2007 01:48:06 Ben Hodgetts (Enverex) wrote:
diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 90fa9b0..5984790 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -3767,9 +3767,11 @@ SOCKET WINAPI WSASocketW(int af, int type, int protocol, if (GetLastError() == WSAEACCES) /* raw socket denied */ { if (type == SOCK_RAW) - MESSAGE("WARNING: Trying to create a socket of type SOCK_RAW, will fail unless running as root\n");
Your mail client mangled the long lines. Please make sure to actually attach the patch before sending. git-format-patch does that when given the --attach parameter. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Change the wording so that users aren't told to run Wine as root any more as that's unsupported and dangerous. Instead specify that they need special permissions to be able to create the socket (sockets can be created without the need to be root specifically). Also cuts the lines down below the 80 char mark. - --- dlls/ws2_32/socket.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGiB/3uqCUopk11kIRAtCIAJ9ApRKM0rbp/w73EabqK2MKXJoVEQCcCtDh eXD5owofcCmFlW1uj6hdF0Q= =7UA7 -----END PGP SIGNATURE-----
On Sunday 01 July 2007 23:43:19 Ben Hodgetts (Enverex) wrote:
Change the wording so that users aren't told to run Wine as root any more as that's unsupported and dangerous. Instead specify that they need special permissions to be able to create the socket (sockets can be created without the need to be root specifically). Also cuts the lines down below the 80 char mark. --- dlls/ws2_32/socket.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
Much better. Now please send this to wine-patches :) Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.
participants (2)
-
Ben Hodgetts (Enverex) -
Kai Blin