Re: [v2 2/2] d3dx9/tests: Add more tests for preshader relative addressing.

[Matteo Bruni]

2017-03-24 23:12 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>:
> Signed-off-by: Paul Gofman <gofmanp(a)gmail.com>

Again, I'd separate the update of the test effect blob and the
existing test from the addition of a new test.

Aside from that, I just had a quick glance.
expected_light_specular_2[] doesn't seem like a good name, you can
call that "test_light_specular_2" or similar and rename its "result"
field "expected" (i.e. always calling the table driving the test
"test_something" is nice and consistent, as is calling the array with
expected results "expected").