Re: [PATCH] comctl32/imagelist: fix ImageList_Read/Write.
20 Jun
2018
20 Jun
'18
7:34 a.m.
Hi Denis, Thanks for taking the time. I noticed a few issues with your patch. 1. Using C++ style comments. 2. Mixing style only changes, please separate them if you really need to make style changes. Usually, I prefer not to touch the old code simply for style changes. 3. Add a conformance test for the problem you intent to fix. 4. Add a version to patch mail subject. You might want to read https://wiki.winehq.org/Submitting_Patches Regards, Zhiyi
2740
Age (days ago)
2740
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zhiyi Zhang