Re: [advapi32] Added check for NULL pointer being passed to QueryServiceStatus as lpservicesstatus parameter.

[Nikolay Sivov]

On 12/18/2010 18:46, Damian Dixon wrote:
> ---
>   dlls/advapi32/service.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c
> index 7fea937..f8d329f 100644
> --- a/dlls/advapi32/service.c
> +++ b/dlls/advapi32/service.c
> @@ -1130,6 +1130,7 @@ BOOL WINAPI QueryServiceStatus(SC_HANDLE hService,
>
> TRACE("%p %p\n", hService, lpservicestatus);
>
> +    if (!lpservicestatus) return FALSE;
>       ret = QueryServiceStatusEx(hService, SC_STATUS_PROCESS_INFO,
> (LPBYTE)&SvcStatusData,
>                                   sizeof(SERVICE_STATUS_PROCESS),&dummy);
>       if (ret) memcpy(lpservicestatus,&SvcStatusData, sizeof(SERVICE_STATUS))
> ;
> Add a test for that please. Also last error is probably affected by this.