Re: [PATCH] dpnet: IDirectPlay8ThreadPool is a singleton interface.

[Sebastian Lackner]

On 17.02.2017 07:43, Alistair Leslie-Hughes wrote:
> -    ok(pool1 != pool2, "same pointer returned.\n");
> +    todo_wine ok(pool1 != pool2, "same pointer returned.\n");

Well, this test shows that its not implemented as a singleton interface
on Windows. Just because part of the state is global doesn't necessarily
mean you don't need any interface specific data.

[PATCH] dpnet: IDirectPlay8ThreadPool is a singleton interface.

[Alistair Leslie-Hughes]

On 17/02/17 18:00, Sebastian Lackner wrote:
> On 17.02.2017 07:43, Alistair Leslie-Hughes wrote:
> > -    ok(pool1 != pool2, "same pointer returned.\n");
> > +    todo_wine ok(pool1 != pool2, "same pointer returned.\n");
>
> Well, this test shows that its not implemented as a singleton interface
> on Windows. Just because part of the state is global doesn't necessarily
> mean you don't need any interface specific data.

Thanks for the feedback.  I see what you mean, a few globals variables
would seem better.

Thanks
 Alistair Leslie-Hughes