[PATCH] winhttp/tests: Fix more test failures.
Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> --- dlls/winhttp/tests/winhttp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 552f6ce778..2cf6f6a87d 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -3578,7 +3578,12 @@ static void test_passport_auth( int port ) ok( ret, "got %u\n", GetLastError() ); ret = WinHttpReceiveResponse( req, NULL ); - ok( ret, "got %u\n", GetLastError() ); + ok( ret || broken(!ret && GetLastError() == ERROR_WINHTTP_LOGIN_FAILURE) /* winxp */, "got %u\n", GetLastError() ); + if (!ret && GetLastError() == ERROR_WINHTTP_LOGIN_FAILURE) + { + win_skip("no support for Passport redirects\n"); + goto cleanup; + } status = 0xdeadbeef; size = sizeof(status); @@ -3602,6 +3607,7 @@ static void test_passport_auth( int port ) ok( !lstrcmpW(headersW, buf), "got %s\n", wine_dbgstr_w(buf) ); } +cleanup: WinHttpCloseHandle( req ); WinHttpCloseHandle( con ); WinHttpCloseHandle( ses ); -- 2.20.1
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57351 Your paranoid android. === build (build log) === Task errors: The previous 1 run(s) terminated abnormally === w7pro64 (task log) === Task errors: channel 2: open failed: connect failed: No route to host channel 2: open failed: connect failed: No route to host BotError: The test VM is powered off! Did the test shut it down?
participants (2)
-
Hans Leidekker -
Marvin