Re: winspool: updated some traces for bug 4268

[Huw D M Davies]

On Fri, Jan 13, 2006 at 03:51:36PM +0100, Detlef Riekenberg wrote:
> Changelog:
>
> - winspool: updated some traces for bug 4268
>
> -- 
> By By ...
>       ... Detlef
> diff --git a/dlls/winspool/info.c b/dlls/winspool/info.c
> index 9b1771d..a4caa39 100644
> --- a/dlls/winspool/info.c
> +++ b/dlls/winspool/info.c
> @@ -247,13 +247,16 @@ static BOOL CUPS_LoadPrinters(void)
>      HKEY hkeyPrinter, hkeyPrinters, hkey;
>
> cupshandle = wine_dlopen(SONAME_LIBCUPS, RTLD_NOW, NULL, 0);
> +    TRACE("%p: CUPS loaded (%s)\n", cupshandle, SONAME_LIBCUPS);
>      if (!cupshandle) 
>   return FALSE;
> -    TRACE("loaded %s\n", SONAME_LIBCUPS);

That's a very confusing TRACE.  If wine_dlopen fails then why not
print out something like "CUPS not loaded" ?
> @@ -439,6 +442,8 @@ PRINTCAP_LoadPrinters(void) {
>      BOOL had_bash = FALSE;
>
> f = fopen("/etc/printcap","r");
> +    TRACE("%p: using /etc/printcap\n", f);
> +
>      if (!f)
>   return FALSE;

The same applies to this too.

Huw.
-- 
Huw Davies
huw(a)codeweavers.com