Wine staging 3.20 release

[Alistair Leslie-Hughes]

Binary packages for various distributions will be available from:
https://www.winehq.org/download

Summary of the past few weeks
* Rebased to current wine 3.20 (857 patches are applied to wine vanilla)
* Reviewed and upstreamed patches.

Upstreamed (Either directly from staging or fixed with a similar patch).
* xaudio2_7: Use assembly wrapper to call OnVoiceProcessingPassStart
callback.
 
Added
* [36089] wined3d: Improve dirt rendering in SpinTires


Where can you help
* Run Steam/Battle.net/UPlay.
* Try you favorite game: SpinTires, Halo online
* Test your favorite applications.
* Steal staging patches and get them accepted upstream.

As always, if you find a bug, please report it via
https://bugs.winehq.org

Best Regards
 Alistair.

[Henri Verbeet]

On Sun, 11 Nov 2018 at 10:38, Alistair Leslie-Hughes
<leslie_alistair(a)hotmail.com> wrote:
> Added
> * [36089] wined3d: Improve dirt rendering in SpinTires

You really don't want to do that unconditionally.

Advice regarding problem with SetFileInformationByHandle

[Greg]

Hello,

Myself and others have been trying to get Star Citizen to install in 
with wine. The first problem that we encountered is that when 
SetFileInformationByHandle is called with a class of 
FileIoPriorityHintInfo, it is hard coded to return 
ERROR_CALL_NOT_IMPLEMENTED.
This seems reasonable, however when the star citizen installer 
encounters that it exits - I'm guessing that it does not check GetLastError.
I have a patch developed by one of my in game org mates, that makes it 
return TRUE for this case without actually doing anything other than 
report a fixme.
The advice I am seeking is: Should I work up a test to go with it and 
submit this patch? I hesitate to do it because the current behavior 
seems accurate, and I would be asking far a special case just  for a 
game I want to play.  On the other hand, I don't think that there will 
ever be a unix equivalent, and that the OS has done as much as it can, 
so maybe it is not a "sin" after all?

I would be thankful for any guidance that can be provided.

Regards,

Greg.

Advice regarding problem with SetFileInformationByHandle

[Fabian Maurer]

Hello Greg,

now I'm not an authority on this, but just making it return a success 
code and have a fixme seems fine to me. If you look around, it 
wouldn't be the first place where this happens either.
Tests won't harm, but then again a success error code is to be 
expected, IMHO. I'd just send in the patch to make it return TRUE and 
a success error code for this specific flag.

Regards,
Fabian Maurer

Advice regarding problem with SetFileInformationByHandle

[Gabriel Ivăncescu]

On Mon, Nov 12, 2018 at 4:55 PM Fabian Maurer <dark.shadow4(a)web.de> wrote:
> Hello Greg,
>
> now I'm not an authority on this, but just making it return a success code and have a fixme seems fine to me. If you look around, it wouldn't be the first place where this happens either.
> Tests won't harm, but then again a success error code is to be expected, IMHO. I'd just send in the patch to make it return TRUE and a success error code for this specific flag.
>
> Regards,
>
> Fabian Maurer

I looked it up. FWIW, it is essentially a hint, so the Windows driver
isn't even required to abide by it. To me it makes no sense to return
error from this at all, especially since it breaks some apps. Wine
could just ignore the "hint".