[PATCH] user32/tests: Remove the todo_wine from a test that succeeds in Wine.

[Francois Gouget]

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
---
At least it does succeed in Wine on the TestBot VMs and the cw-gtx560
and cw-rx460 machines. Maybe it fails on some other machines?
It even succeeds on my box (KDE) though not always and sometimes the
following 'ShowWindow(SW_SHOWMINIMIZED):overlapped' test fails instead.
---
 dlls/user32/tests/msg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 9867e319d58..b5228f8facb 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -5405,7 +5405,7 @@ static void test_messages(void)
 
     ShowWindow(hwnd, SW_MINIMIZE);
     flush_events();
-    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
+    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
     flush_sequence();
 
     if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=94201

Your paranoid android.


=== debiant2 (32 bit Chinese:China report) ===

user32:
msg.c:14834: Test failed: bad time 11b9d97c

[Zebediah Figura (she/her)]

On 7/18/21 1:56 AM, Francois Gouget wrote:
> Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
> ---
> At least it does succeed in Wine on the TestBot VMs and the cw-gtx560
> and cw-rx460 machines. Maybe it fails on some other machines?
> It even succeeds on my box (KDE) though not always and sometimes the
> following 'ShowWindow(SW_SHOWMINIMIZED):overlapped' test fails instead.
> ---
>   dlls/user32/tests/msg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
> index 9867e319d58..b5228f8facb 100644
> --- a/dlls/user32/tests/msg.c
> +++ b/dlls/user32/tests/msg.c
> @@ -5405,7 +5405,7 @@ static void test_messages(void)
>
> ShowWindow(hwnd, SW_MINIMIZE);
>       flush_events();
> -    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", TRUE);
> +    ok_sequence(WmShowMinOverlappedSeq, "ShowWindow(SW_SHOWMINIMIZED):overlapped", FALSE);
>       flush_sequence();
>
> if (GetWindowLongW( hwnd, GWL_STYLE ) & WS_MINIMIZE)

This is the fourth (?) time someone's tried to "fix" this test:

https://www.winehq.org/pipermail/wine-devel/2019-May/146432.html

We've also had three attempts to actually fix the code, at least one of 
which was resent, all of which fell off the list without review:

https://www.winehq.org/pipermail/wine-devel/2018-January/121877.html

https://www.winehq.org/pipermail/wine-devel/2020-March/161044.html

[Francois Gouget]

On Sun, 18 Jul 2021, Zebediah Figura (she/her) wrote:
[...]
> This is the fourth (?) time someone's tried to "fix" this test:
>
> https://www.winehq.org/pipermail/wine-devel/2019-May/146432.html

Ah. I was not aware of those.

I see the objection with the previous attempts is that it this test does 
not not work consistently in all window managers. But does this actually 
matter?

It works consistently on the TestBot VMs and it seems like that should 
be the reference rather than arguments it fails and so and so's machine.

I guess the one exception here is Alexandre's test machine but my 
understanding is that he also uses fvwm. So I see no reason why the test 
wouldn't succeed on his machine too. Or maybe the fvwm config file is 
different?


-- 
Francois Gouget <fgouget(a)codeweavers.com>