Re: MSIEXEC: Make installation of InstMsiA.exe possible

[Dmitry Timoshkov]

"Hans Leidekker" <hans(a)it.vu.nl> wrote:
> @@ -523,6 +524,11 @@
>   {
>   InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_PROGRESSONLY;
>   }
> + else if(!strcasecmp(argv[i]+2, "b+!"))

Please use lstrcmpiA instead of strcasecmp. A difference between unix
system locale and current ANSI code page in Wine might lead to undesired
side effects.

-- 
Dmitry.

MSIEXEC: Make installation of InstMsiA.exe possible

[Hans Leidekker]

On Saturday 6 November 2004 15:52, Dmitry Timoshkov wrote:
> > + else if(!strcasecmp(argv[i]+2, "b+!"))
>
> Please use lstrcmpiA instead of strcasecmp. A difference between unix
> system locale and current ANSI code page in Wine might lead to undesired
> side effects.

Here's a patch relative to my previous patch that replaces all occurrences
of strcasecmp with lstrcmpiA. It also introduces MSIEXEC_lstrncmpiA (wrapper
around CompareString) to replace all occurrences of strncasecmp.

Changelog:
  Use string functions that are Windows locale aware.