Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost

[Paul Vriens]

On 03/23/2010 02:08 PM, Sébastien Ramage wrote:
> Fixes bug #16595
> ---
> dlls/user32/scroll.c | 5 +----
> dlls/user32/tests/scroll.c | 17 ++++++++++++++++-
> 2 files changed, 17 insertions(+), 5 deletions(-)

Hi Sébastien

Can comment too much on the patch but this patch doesn't apply cleanly 
to current Git. Please make sure that all patches are based on top of 
current.
> diff --git a/dlls/user32/scroll.c b/dlls/user32/scroll.c
> index 93f85f2..91adb74 100644
> --- a/dlls/user32/scroll.c
> +++ b/dlls/user32/scroll.c
> @@ -1105,11 +1105,8 @@ void SCROLL_TrackScrollBar( HWND hwnd, INT
> scrollbar, POINT pt )
> DispatchMessageW(&msg );
> }
> if (!IsWindow( hwnd ))
> - {
> ReleaseCapture();
> - break;
> - }
> - } while (msg.message != WM_LBUTTONUP);
> + } while (msg.message != WM_LBUTTONUP&& GetCapture() == hwnd);
> }

While you're at it please add a space before the '&&'.

-- 
Cheers,

Paul.