[PATCH 1/1] wininet: Fix crash when connection is null in NETCON_secure_connect

[Wei Xie]

request->netconn may be released before call NETCON_secure_connect.

5029             if(!request->contentLength)
5030                 http_release_netconn(request, TRUE);


5121             if (secure_proxy_connect && request->status_code == HTTP_STATUS_OK)
5122             {
5123                 res = NETCON_secure_connect(request->netconn, request->server);





I don't know how write a test patch




------------------

武汉深之度科技有限公司
Wuhan Deepin Technology Co., Ltd.

　　谢威

手机：[phone]


武汉：武汉市光谷大道77号光谷金融港B18栋6楼 
北京：北京市西城区新街口外大街28号院普天德胜B座603室
上海：上海市长宁区愚园路1258号15A01室


官网：www.deepin.org　　官博：深度操作系统

[Jacek Caban]

Hi Wei,

On 05.01.2018 02:03, Wei Xie wrote:
> request->netconn may be released before call NETCON_secure_connect.
>
> 5029             if(!request->contentLength)
> 5030                 http_release_netconn(request, TRUE);
>
> 5121             if (secure_proxy_connect && request->status_code ==
> HTTP_STATUS_OK)
> 5122             {
> 5123                 res = NETCON_secure_connect(request->netconn,
> request->server);
>
> I don't know how write a test patch

The whole secure_proxy_connect could really use a rewrite, but for this
particular problem, I think that the right solution would be to not
release connection in line 5030 if secure_proxy_connect is TRUE.


Thanks,

Jacek

[PATCH] wininet: Fix crash when secure_proxy_connect use a rewrite

[Wei Xie]

------------------ Original ------------------
From:  "Jacek Caban"<jacek(a)codeweavers.com>;
Date:  Thu, Jan 11, 2018 05:04 AM
To:  "Wei Xie"<xiewei(a)deepin.com>; "wine-devel"<wine-devel(a)winehq.org>;
Subject:  Re: [PATCH 1/1] wininet: Fix crash when connection is null inNETCON_secure_connect
 
Hi Wei,

On 05.01.2018 02:03, Wei Xie wrote:
> request->netconn may be released before call NETCON_secure_connect.
>
> 5029             if(!request->contentLength)
> 5030                 http_release_netconn(request, TRUE);
>
> 5121             if (secure_proxy_connect && request->status_code ==
> HTTP_STATUS_OK)
> 5122             {
> 5123                 res = NETCON_secure_connect(request->netconn,
> request->server);
>
> I don't know how write a test patch

The whole secure_proxy_connect could really use a rewrite, but for this
particular problem, I think that the right solution would be to not
release connection in line 5030 if secure_proxy_connect is TRUE.


Thanks,

Jacek

[PATCH] wininet: Fix crash when secure_proxy_connect use a rewrite

[Jacek Caban]

Hi Wei,

The patch looks good to me now. However, we're late in code freeze
phrase and this patch is invasive for not widely tested setups, so I'd
prefer to defer it until after code freeze. Please resend it after Wine
3.0 is released.

Thanks,
Jacek