Regression in "Braveheart"

[Carlos Lozano]

Hello,

The patch:
http://www.winehq.org/hypermail/wine-cvs/2004/06/0104.html

Log message:
  Dmitry Timoshkov <dmitry(a)codeweavers.com>
  Do nothing in ShowWindow(SW_SHOW) if a window is already visible.

Causes regression in the game "Braveheart". The intro was
working before of the patch, now it freezes with black screen
on start.

Regards,
Carlos.

-- 
 ___         _          \  |  /  Consulting
| . |._ _  _| | ___  ___  ___    http://www.andago.com
|   || ' |/ . |<_> |/ . |/ . \__ GNU/Linux
|_|_||_|_|\___|<___|\_. |\___/     _ \  __|\ \  /
 Carlos A. Lozano   <___'/ | \ -_) __/\__ \ >  <  -_)
 [ carlos.lozano(a)andago.com ]\___|_|  ____/ _/\_\___|
 [ calb(a)epsxe.com           ]  http://www.ePSXe.com

[Dmitry Timoshkov]

"Carlos Lozano" <clozano(a)andago.com> wrote:
> The patch:
> http://www.winehq.org/hypermail/wine-cvs/2004/06/0104.html
>
> Log message:
>   Dmitry Timoshkov <dmitry(a)codeweavers.com>
>   Do nothing in ShowWindow(SW_SHOW) if a window is already visible.
>
> Causes regression in the game "Braveheart". The intro was
> working before of the patch, now it freezes with black screen
> on start.

We have a test in dlls/user/tests/msg.c,test_messages() which confirms
that the patch is correct at least for overlapped windows and SW_SHOW
command ("ShowWindow(SW_SHOW):overlapped already visible"). What window
styles does the affected window have, and what command is passed to
ShowWindow()?

-- 
Dmitry.