Re: [docs] winedev: A hint for patch separation

[Jerome Leclanche]

That sounds like we want people to avoid testing wine. How about
"Patches must not break building Wine nor its testsuite. Adding dead
code should also be avoided."?  </bikeshed>

J. Leclanche



2011/6/26 André Hentschel <nerv(a)dawncrow.de>:
> ---
>  en/winedev-coding.sgml |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/en/winedev-coding.sgml b/en/winedev-coding.sgml
> index eacf6d8..8b0f0d9 100644
> --- a/en/winedev-coding.sgml
> +++ b/en/winedev-coding.sgml
> @@ -207,6 +207,10 @@ code
>         is your friend!
>       </para>
>       <para>
> +        Every patch must not break building and testing Wine and
> +        adding dead code should be avoided.
> +      </para>
> +      <para>
>         Save yourself some embarrassment and run your patched code
>         against more than just your current test example.  Experience
>         will tell you how much effort to apply here. If there are
> --
>
> Best Regards, André Hentschel

[docs] winedev: A hint for patch separation

[André Hentschel]

Am 27.06.2011 11:55, schrieb Jerome Leclanche:
> That sounds like we want people to avoid testing wine. How about
> "Patches must not break building Wine nor its testsuite. Adding dead
> code should also be avoided."?  </bikeshed>

Yes, sounds better.

-- 

Best Regards, André Hentschel