[PATCH 1/4] d3dx9: Use BitScanReverse in make_pow2.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
I left behaviour for num == 1 unchanged, but according to the comment it 
should be 0. We don't seem to have a test for that.

  dlls/d3dx9_36/d3dx9_private.h | 15 ++-------------
  1 file changed, 2 insertions(+), 13 deletions(-)

[Matteo Bruni]

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>

[Matteo Bruni]

On Wed, Jun 10, 2020 at 2:21 PM Jacek Caban <jacek(a)codeweavers.com> wrote:
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> ---
> I left behaviour for num == 1 unchanged, but according to the comment it
> should be 0. We don't seem to have a test for that.

You mean for num == 0? That's sort of an invalid value, it shouldn't
matter (and returning 1 for that seems safer anyway).

[Jacek Caban]

On 11.06.2020 22:13, Matteo Bruni wrote:
> On Wed, Jun 10, 2020 at 2:21 PM Jacek Caban <jacek(a)codeweavers.com> wrote:
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > ---
> > I left behaviour for num == 1 unchanged, but according to the comment it
> > should be 0. We don't seem to have a test for that.
> > You mean for num == 0? That's sort of an invalid value, it shouldn't
> > matter (and returning 1 for that seems safer anyway).

Oh, right, that comment was messed up.


Thanks for the review,

Jacek