wininet HTTP_HttpSendRequestW problem -- with correct attachment
Hello, Previous mail had the wrong file attached -- sorry for that I tried - as some sort experiment - to install java, but this fails; I decided to look into it and found some check in HTTP_HttpSendRequestW (wininet) is missing (patch attached to get the installer past that, probably not correct) I don't know what error code to set, so I didn't set any; after finishing a download the installer stops; I conclude at least something really is not going correct here ;) If it's just this program... no problem; but probably something really is not correct somewhere there; It seems the java installer somehow feeds illegal data to the function, so more may be wrong; I also attached part of the wininet trace untill it jumps into that code; regards, Joris Index: dlls/wininet/http.c =================================================================== RCS file: /home/wine/wine/dlls/wininet/http.c,v retrieving revision 1.95 diff -u -p -r1.95 http.c --- dlls/wininet/http.c 2 Feb 2005 09:56:35 -0000 1.95 +++ dlls/wininet/http.c 9 Mar 2005 15:32:35 -0000 @@ -1694,6 +1694,14 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWINI setCookieHeader = &lpwhr->pCustHeaders[CustHeaderIndex]; + if (lpwhr->pCustHeaders[CustHeaderIndex].lpszValue == NULL) + { + TRACE("field lpszValue is incorrect\n"); + /* FIXME: set error */ + bSuccess = FALSE; + goto lend; + } + while (setCookieHeader->lpszValue[nPosEnd] != '\0') { LPWSTR buf_cookie, cookie_name, cookie_data; Script started on Wed Mar 9 16:33:02 2005 jorishuizer(a)debian:~$ WINEDEBUG=+wininet wine jre-1_5_0_01-windows-i586-p-iftw. .exe trace:wininet:DllMain 0x40a60000,1,0x1 trace:wininet:InternetOpenA ("Mozilla/4.0 (compatible; Win32; jinstall)", 0x00000000, (null), (null), 0x00000000) trace:wininet:InternetOpenW (L"Mozilla/4.0 (compatible; Win32; jinstall)", 0, (null), (null), 0) trace:wininet:InternetOpenW access type : INTERNET_OPEN_TYPE_PRECONFIG trace:wininet:InternetOpenW flags : trace:wininet:WININET_AddRef 0x403b8c60 -> refcount = 2 trace:wininet:WININET_Release object 0x403b8c60 refcount = 1 trace:wininet:InternetOpenW returning 0x403b8c60 trace:wininet:InternetCrackUrlW (L"http://java.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1...." 91 0 0x406aa4e0) trace:wininet:GetInternetSchemeW trace:wininet:SetUrlComponentValueW L"http"... (4) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW L"java.sun.com"... (12) trace:wininet:SetUrlComponentValueW L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi" (72) trace:wininet:InternetCrackUrlW L"http://java.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1....": host(L"java.sun.com"...) path(L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi") extra((null)) trace:wininet:InternetCrackUrlA http://java.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1....: scheme((null)) host("java.sun.com") path("/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi") extra("") trace:wininet:InternetConnectW (0x1, L"java.sun.com", 0, L"", L"", 3, 0, 0) trace:wininet:WININET_AddRef 0x403b8c60 -> refcount = 2 trace:wininet:WININET_GetObject handle 1 -> 0x403b8c60 trace:wininet:HTTP_Connect --> trace:wininet:WININET_AddRef 0x403b8c60 -> refcount = 3 trace:wininet:WININET_AddRef 0x403b8d70 -> refcount = 2 trace:wininet:SendAsyncCallback (0x403b8d70, 00000000, 60 (INTERNET_STATUS_HANDLE_CREATED), 0x406aa474, 8): non async call with callback (nil) trace:wininet:WININET_Release object 0x403b8d70 refcount = 1 trace:wininet:HTTP_Connect 0x403b8c60 --> 0x2 (0x403b8d70) trace:wininet:WININET_Release object 0x403b8c60 refcount = 2 trace:wininet:InternetConnectW returning 0x2 trace:wininet:HttpOpenRequestA (0x2, "HEAD", "/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi", "HTTP/1.1", "", (nil), 04440000, 00000000) trace:wininet:HttpOpenRequestW (0x2, L"HEAD", L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi", L"HTTP/1.1", L"", (nil), 04440000, 00000000) trace:wininet:WININET_AddRef 0x403b8d70 -> refcount = 2 trace:wininet:WININET_GetObject handle 2 -> 0x403b8d70 trace:wininet:HTTP_HttpOpenRequestW --> trace:wininet:WININET_AddRef 0x403b8d70 -> refcount = 3 trace:wininet:WININET_AddRef 0x403b8ea8 -> refcount = 2 trace:wininet:HTTP_ProcessHeader --> L"Host": L"java.sun.com" - 0xa2000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:HTTP_HttpAddRequestHeadersW copying header: L"User-Agent: Mozilla/4.0 (compatible; Win32; jinstall)\r\n" trace:wininet:HTTP_HttpAddRequestHeadersW interpreting header L"User-Agent: Mozilla/4.0 (compatible; Win32; jinstall)" trace:wininet:HTTP_InterpretHttpHeader field(L"User-Agent") Value(L"Mozilla/4.0 (compatible; Win32; jinstall)") trace:wininet:HTTP_ProcessHeader --> L"User-Agent": L"Mozilla/4.0 (compatible; Win32; jinstall)" - 0x22000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:InternetGetCookieW (L"http://java.sun.com", (null), (nil), 0x406aa344) trace:wininet:InternetCrackUrlW (L"http://java.sun.com" 19 0 0x406a825c) trace:wininet:GetInternetSchemeW trace:wininet:SetUrlComponentValueW L"http"... (4) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW L"java.sun.com" (12) trace:wininet:InternetCrackUrlW L"http://java.sun.com": host(L"java.sun.com") path(L"") extra((null)) trace:wininet:InternetGetCookieW returning trace:wininet:InternetGetCookieW (L"http://java.sun.com", (null), 0x403b93e0, 0x406aa344) trace:wininet:InternetCrackUrlW (L"http://java.sun.com" 19 0 0x406a825c) trace:wininet:GetInternetSchemeW trace:wininet:SetUrlComponentValueW L"http"... (4) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW L"java.sun.com" (12) trace:wininet:InternetCrackUrlW L"http://java.sun.com": host(L"java.sun.com") path(L"") extra((null)) trace:wininet:HTTP_HttpAddRequestHeadersW copying header: L"Cookie: \r\n" trace:wininet:HTTP_HttpAddRequestHeadersW interpreting header L"Cookie: " trace:wininet:HTTP_InterpretHttpHeader field(L"Cookie") Value(L"") trace:wininet:HTTP_ProcessHeader --> L"Cookie": L"" - 0x22000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:SendAsyncCallback (0x403b8d70, 00000000, 60 (INTERNET_STATUS_HANDLE_CREATED), 0x406aa33c, 8): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 10 (INTERNET_STATUS_RESOLVING_NAME), 0x403b8dc0, 13): non async call with callback (nil) trace:wininet:GetAddress L"java.sun.com" trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 11 (INTERNET_STATUS_NAME_RESOLVED), 0x403b8da0, 16): non async call with callback (nil) trace:wininet:WININET_Release object 0x403b8ea8 refcount = 1 trace:wininet:HTTP_HttpOpenRequestW <-- 0x3 (0x403b8ea8) trace:wininet:WININET_Release object 0x403b8d70 refcount = 2 trace:wininet:HttpOpenRequestW returning 0x3 trace:wininet:HttpSendRequestW 0x3, (nil) ((null)), 0, (nil), 0) trace:wininet:WININET_AddRef 0x403b8ea8 -> refcount = 2 trace:wininet:WININET_GetObject handle 3 -> 0x403b8ea8 trace:wininet:HTTP_HttpSendRequestW --> 0x403b8ea8 trace:wininet:HTTP_HttpSendRequestW Going to url L"java.sun.com" L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi" trace:wininet:HTTP_HttpSendRequestW Adding header L"User-Agent" (L"Mozilla/4.0 (compatible; Win32; jinstall)") trace:wininet:HTTP_HttpSendRequestW Adding header L"Cookie" (L"") trace:wininet:HTTP_HttpSendRequestW Adding header L"Host" (L"java.sun.com") trace:wininet:HTTP_HttpSendRequestW Request header -> L"HEAD /webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi HTTP/1.0\r\nUser-Agent: Mozilla/4.0 (compatible; Win32; jinstall)\r\nCookie: \r\nHost: java.sun.com\r\n\r\n" trace:wininet:HTTP_OpenConnection --> trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 20 (INTERNET_STATUS_CONNECTING_TO_SERVER), 0x403b8da0, 16): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 21 (INTERNET_STATUS_CONNECTED_TO_SERVER), 0x403b8da0, 16): non async call with callback (nil) trace:wininet:HTTP_OpenConnection 1 <-- trace:wininet:HTTP_HttpSendRequestW full request -> HEAD /webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi HTTP/1.0 User-Agent: Mozilla/4.0 (compatible; Win32; jinstall) Cookie: Host: java.sun.com trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 30 (INTERNET_STATUS_SENDING_REQUEST), (nil), 0): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 31 (INTERNET_STATUS_REQUEST_SENT), 0x406a9418, 4): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 40 (INTERNET_STATUS_RECEIVING_RESPONSE), (nil), 0): non async call with callback (nil) trace:wininet:HTTP_GetResponseHeaders --> trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :31 HTTP/1.1 302 Moved Temporarily trace:wininet:HTTP_GetResponseHeaders version [L"HTTP/1.1"] status code [L"302"] status text [L"Moved Temporarily"] trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :31 Server: Sun-ONE-Web-Server/6.1 trace:wininet:HTTP_GetResponseHeaders got line "Server: Sun-ONE-Web-Server/6.1", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Server") Value(L"Sun-ONE-Web-Server/6.1") trace:wininet:HTTP_ProcessHeader --> L"Server": L"Sun-ONE-Web-Server/6.1" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :36 Date: Wed, 09 Mar 2005 15:30:43 GMT trace:wininet:HTTP_GetResponseHeaders got line "Date: Wed, 09 Mar 2005 15:30:43 GMT", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Date") Value(L"Wed, 09 Mar 2005 15:30:43 GMT") trace:wininet:HTTP_ProcessHeader --> L"Date": L"Wed, 09 Mar 2005 15:30:43 GMT" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :24 Content-type: text/html trace:wininet:HTTP_GetResponseHeaders got line "Content-type: text/html", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Content-type") Value(L"text/html") trace:wininet:HTTP_ProcessHeader --> L"Content-type": L"text/html" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :116 Set-Cookie: SUN_ID=80.60.97.18:79481110382243; EXPIRES=Wednesday, 31-Dec-2025 23:59:59 GMT; DOMAIN=.sun.com; PATH=/ trace:wininet:HTTP_GetResponseHeaders got line "Set-Cookie: SUN_ID=80.60.97.18:79481110382243; EXPIRES=Wednesday, 31-Dec-2025 23:59:59 GMT; DOMAIN=.sun.com; PATH=/", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Set-Cookie") Value(L"SUN_ID=80.60.97.18:79481110382243; EXPIRES=Wednesday, 31-Dec-2025 23:59:59 GMT; DOMAIN=.sun.com; PATH=/") trace:wininet:HTTP_ProcessHeader --> L"Set-Cookie": L"SUN_ID=80.60.97.18:79481110382243; EXPIRES=Wednesday, 31-Dec-2025 23:59:59 GMT; DOMAIN=.sun.com; PATH=/" - 0xa0000000 trace:wininet:HTTP_GetStdHeaderIndex Couldn't find L"Set-Cookie" in standard header table trace:wininet:HTTP_GetCustomHeaderIndex L"Set-Cookie" trace:wininet:HTTP_GetCustomHeaderIndex Return: -1 trace:wininet:HTTP_InsertCustomHeader --> L"Set-Cookie": L"SUN_ID=80.60.97.18:79481110382243; EXPIRES=Wednesday, 31-Dec-2025 23:59:59 GMT; DOMAIN=.sun.com; PATH=/" trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :101 Location: http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5... trace:wininet:HTTP_GetResponseHeaders got line "Location: http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5...", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Location") Value(L"http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5...") trace:wininet:HTTP_ProcessHeader --> L"Location": L"http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5..." - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :18 Connection: close trace:wininet:HTTP_GetResponseHeaders got line "Connection: close", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Connection") Value(L"close") trace:wininet:HTTP_ProcessHeader --> L"Connection": L"close" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :1 trace:wininet:HTTP_GetResponseHeaders got line "", now interpreting trace:wininet:HTTP_GetResponseHeaders raw headers: L"HTTP/1.1 302 Moved Temporarily\r\nServer: Sun-ONE-Web-Server/6.1\r\nDate: Wed, 09 Mar 2005 15:30:43 GMT\r\nContent-type: text/html\r\nSet-Cookie: SUN_ID=80.60.97.18:79481110382243; EXPIRES=Wednesday, 31-Dec-2025 23:59:59 GMT; DOMAIN=.sun.com; PATH=/\r\nLocation: http://jdl.sun.com/webapps/download/Ge"... trace:wininet:HTTP_GetResponseHeaders <-- trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 41 (INTERNET_STATUS_RESPONSE_RECEIVED), 0x406a9414, 4): non async call with callback (nil) trace:wininet:HTTP_GetCustomHeaderIndex L"Set-Cookie" trace:wininet:HTTP_GetCustomHeaderIndex Return: 0 trace:wininet:HTTP_HttpSendRequestW L"SUN_ID=80.60.97.18:79481110382243" trace:wininet:InternetSetCookieW (L"http://java.sun.com/",L"SUN_ID",L"80.60.97.18:79481110382243") trace:wininet:InternetCrackUrlW (L"http://java.sun.com/" 20 0 0x406a72ec) trace:wininet:GetInternetSchemeW trace:wininet:SetUrlComponentValueW L"http"... (4) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW L"java.sun.com"... (12) trace:wininet:SetUrlComponentValueW L"/" (1) trace:wininet:InternetCrackUrlW L"http://java.sun.com/": host(L"java.sun.com") path(L"/") extra((null)) trace:wininet:COOKIE_addDomain Adding domain: 0x403b8c20 trace:wininet:COOKIE_findCookie (0x403b8c20, L"SUN_ID") trace:wininet:COOKIE_addCookie added cookie 0x403b98f0 (data is L"80.60.97.18:79481110382243") trace:wininet:HTTP_HttpSendRequestW L"" trace:wininet:HTTP_HttpQueryInfoW returning number : 302 trace:wininet:HTTP_HttpQueryInfoW returning string : 'L"http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5..."' trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 110 (INTERNET_STATUS_REDIRECT), 0x406a9420, 180): non async call with callback (nil) trace:wininet:InternetCrackUrlW (L"http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5..." 90 0 0x406a8330) trace:wininet:GetInternetSchemeW trace:wininet:SetUrlComponentValueW L"http"... (4) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW (null) (0) trace:wininet:SetUrlComponentValueW L"jdl.sun.com"... (11) trace:wininet:SetUrlComponentValueW L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi" (72) trace:wininet:InternetCrackUrlW L"http://jdl.sun.com/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5...": host(L"jdl.sun.com") path(L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi") extra(L"\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\0000\dc51\400a\0000\0000\0000\0000\0000\0000\0000\0000\dc51\400a\b9db\40a8\0015\0000\6a9c\406a\dc51\400a\0156\4020\b9c6\40a8\0015\0000\0000\0000\dc51\400a\0000") trace:wininet:HTTP_ProcessHeader --> L"Host": L"jdl.sun.com" - 0xa2000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 10 (INTERNET_STATUS_RESOLVING_NAME), 0x403b8dc0, 12): non async call with callback (nil) trace:wininet:GetAddress L"jdl.sun.com" trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 11 (INTERNET_STATUS_NAME_RESOLVED), 0x403b8da0, 16): non async call with callback (nil) trace:wininet:HTTP_HttpSendRequestW --> 0x403b8ea8 trace:wininet:HTTP_HttpSendRequestW Going to url L"jdl.sun.com" L"/webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi" trace:wininet:HTTP_HttpSendRequestW Adding header L"User-Agent" (L"Mozilla/4.0 (compatible; Win32; jinstall)") trace:wininet:HTTP_HttpSendRequestW Adding header L"Cookie" (L"") trace:wininet:HTTP_HttpSendRequestW Adding header L"Host" (L"jdl.sun.com") trace:wininet:HTTP_HttpSendRequestW Request header -> L"HEAD /webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi HTTP/1.0\r\nUser-Agent: Mozilla/4.0 (compatible; Win32; jinstall)\r\nCookie: \r\nHost: jdl.sun.com\r\n\r\n" trace:wininet:HTTP_OpenConnection --> trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 20 (INTERNET_STATUS_CONNECTING_TO_SERVER), 0x403b8da0, 16): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 21 (INTERNET_STATUS_CONNECTED_TO_SERVER), 0x403b8da0, 16): non async call with callback (nil) trace:wininet:HTTP_OpenConnection 1 <-- trace:wininet:HTTP_HttpSendRequestW full request -> HEAD /webapps/download/GetFile/1.5.0_01-b08/windows-i586/jre1.5.0_01-iftw.msi HTTP/1.0 User-Agent: Mozilla/4.0 (compatible; Win32; jinstall) Cookie: Host: jdl.sun.com trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 30 (INTERNET_STATUS_SENDING_REQUEST), (nil), 0): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 31 (INTERNET_STATUS_REQUEST_SENT), 0x406a597c, 4): non async call with callback (nil) trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 40 (INTERNET_STATUS_RECEIVING_RESPONSE), (nil), 0): non async call with callback (nil) trace:wininet:HTTP_GetResponseHeaders --> trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :31 HTTP/1.1 302 Moved Temporarily trace:wininet:HTTP_GetResponseHeaders version [L"HTTP/1.1"] status code [L"302"] status text [L"Moved Temporarily"] trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :32 Server: Netscape-Enterprise/6.0 trace:wininet:HTTP_GetResponseHeaders got line "Server: Netscape-Enterprise/6.0", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Server") Value(L"Netscape-Enterprise/6.0") trace:wininet:HTTP_ProcessHeader --> L"Server": L"Netscape-Enterprise/6.0" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :36 Date: Wed, 09 Mar 2005 15:25:24 GMT trace:wininet:HTTP_GetResponseHeaders got line "Date: Wed, 09 Mar 2005 15:25:24 GMT", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Date") Value(L"Wed, 09 Mar 2005 15:25:24 GMT") trace:wininet:HTTP_ProcessHeader --> L"Date": L"Wed, 09 Mar 2005 15:25:24 GMT" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :18 Content-length: 0 trace:wininet:HTTP_GetResponseHeaders got line "Content-length: 0", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Content-length") Value(L"0") trace:wininet:HTTP_ProcessHeader --> L"Content-length": L"0" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :25 Content-type: text/plain trace:wininet:HTTP_GetResponseHeaders got line "Content-type: text/plain", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Content-type") Value(L"text/plain") trace:wininet:HTTP_ProcessHeader --> L"Content-type": L"text/plain" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :62 Location: http://jdl.sun.com/update/1.5.0/jre1.5.0_01-b08.msi trace:wininet:HTTP_GetResponseHeaders got line "Location: http://jdl.sun.com/update/1.5.0/jre1.5.0_01-b08.msi", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Location") Value(L"http://jdl.sun.com/update/1.5.0/jre1.5.0_01-b08.msi") trace:wininet:HTTP_ProcessHeader --> L"Location": L"http://jdl.sun.com/update/1.5.0/jre1.5.0_01-b08.msi" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :18 Connection: close trace:wininet:HTTP_GetResponseHeaders got line "Connection: close", now interpreting trace:wininet:HTTP_InterpretHttpHeader field(L"Connection") Value(L"close") trace:wininet:HTTP_ProcessHeader --> L"Connection": L"close" - 0xa0000000 trace:wininet:HTTP_ProcessHeader <-- 1 trace:wininet:NETCON_getNextLine trace:wininet:NETCON_getNextLine :1 trace:wininet:HTTP_GetResponseHeaders got line "", now interpreting trace:wininet:HTTP_GetResponseHeaders raw headers: L"HTTP/1.1 302 Moved Temporarily\r\nServer: Netscape-Enterprise/6.0\r\nDate: Wed, 09 Mar 2005 15:25:24 GMT\r\nContent-length: 0\r\nContent-type: text/plain\r\nLocation: http://jdl.sun.com/update/1.5.0/jre1.5.0_01-b08.msi\r\nConnection: close\r\n\r\n" trace:wininet:HTTP_GetResponseHeaders <-- trace:wininet:SendAsyncCallback (0x403b8ea8, 00000000, 41 (INTERNET_STATUS_RESPONSE_RECEIVED), 0x406a5978, 4): non async call with callback (nil) trace:wininet:HTTP_GetCustomHeaderIndex L"Set-Cookie" trace:wininet:HTTP_GetCustomHeaderIndex Return: 0 trace:wininet:HTTP_HttpSendRequestW field lpszValue is incorrect
Joris Huizer wrote:
Hello,
Previous mail had the wrong file attached -- sorry for that I tried - as some sort experiment - to install java, but this fails; I decided to look into it and found some check in HTTP_HttpSendRequestW (wininet) is missing (patch attached to get the installer past that, probably not correct) I don't know what error code to set, so I didn't set any; after finishing a download the installer stops; I conclude at least something really is not going correct here ;) If it's just this program... no problem; but probably something really is not correct somewhere there;
The patch was ok, but it did not fix the source of the problem. We shouldn't be adding a field if it doesn't have a value. Can you try the attached patch and let me know if it solves the same problem your previous patch did? Rob
Robert Shearman wrote:
Joris Huizer wrote:
Hello,
Previous mail had the wrong file attached -- sorry for that I tried - as some sort experiment - to install java, but this fails; I decided to look into it and found some check in HTTP_HttpSendRequestW (wininet) is missing (patch attached to get the installer past that, probably not correct) I don't know what error code to set, so I didn't set any; after finishing a download the installer stops; I conclude at least something really is not going correct here ;) If it's just this program... no problem; but probably something really is not correct somewhere there;
The patch was ok, but it did not fix the source of the problem. We shouldn't be adding a field if it doesn't have a value. Can you try the attached patch and let me know if it solves the same problem your previous patch did?
Rob
------------------------------------------------------------------------
Index: dlls/wininet/http.c =================================================================== RCS file: /home/wine/wine/dlls/wininet/http.c,v retrieving revision 1.95 diff -u -p -r1.95 http.c --- dlls/wininet/http.c 2 Feb 2005 09:56:35 -0000 1.95 +++ dlls/wininet/http.c 9 Mar 2005 19:01:18 -0000 @@ -2163,6 +2163,7 @@ LPWSTR * HTTP_InterpretHttpHeader(LPCWST if (!pszColon) { HTTP_FreeTokens(pTokenPair); + WARN("No ':' in line: %s\n", debugstr_w(buffer)); return NULL; }
@@ -2190,6 +2191,15 @@ LPWSTR * HTTP_InterpretHttpHeader(LPCWST strip_spaces(pTokenPair[1]);
TRACE("field(%s) Value(%s)\n", debugstr_w(pTokenPair[0]), debugstr_w(pTokenPair[1])); + + if (!*pTokenPair[0] || !*pTokenPair[1]) + { + HTTP_FreeTokens(pTokenPair); + WARN("Either no field or no value: field(%s) Value(%s)\n", + debugstr_w(pTokenPair[0]), debugstr_w(pTokenPair[1])); + return NULL; + } + return pTokenPair; }
No, that one didn't help (attached a new log of a crash after applying this patch, with traces) regards, Joris
Robert Shearman wrote:
Joris Huizer wrote:
Hello,
Previous mail had the wrong file attached -- sorry for that I tried - as some sort experiment - to install java, but this fails; I decided to look into it and found some check in HTTP_HttpSendRequestW (wininet) is missing (patch attached to get the installer past that, probably not correct) I don't know what error code to set, so I didn't set any; after finishing a download the installer stops; I conclude at least something really is not going correct here ;) If it's just this program... no problem; but probably something really is not correct somewhere there;
The patch was ok, but it did not fix the source of the problem. We shouldn't be adding a field if it doesn't have a value. Can you try the attached patch and let me know if it solves the same problem your previous patch did?
Rob
I forgot to tell before -- this java netinstaller program can be download at http://jdl.sun.com/webapps/download/AutoDL?BundleId=9953 regards, Joris
participants (2)
-
Joris Huizer -
Robert Shearman