Re: [1/2] gdiplus: Explicitly copy the bits from dib sections to new bitmaps.
On 12/13/2009 12:59 AM, Vincent Povirk wrote:
Hi Vincent, It appears that this one introduced a test failure: http://test.winehq.org/data/tests/gdiplus:image.html One of the tests that fails now (line 533) was there for a long time it's just that you've added some stuff before that. The other one (line 1058) is because of the other patch "Add test for image palette functions." Could you have a look? -- Cheers, Paul.
It seems the check for palettes larger than 256 was an improvement in windows vista. I guess the test can be removed (or changed to Ok||InvalidParameter), but what does this mean for the Wine implementation? On Tue, Dec 15, 2009 at 4:40 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
On 12/13/2009 12:59 AM, Vincent Povirk wrote:
Hi Vincent,
It appears that this one introduced a test failure:
http://test.winehq.org/data/tests/gdiplus:image.html
One of the tests that fails now (line 533) was there for a long time it's just that you've added some stuff before that.
The other one (line 1058) is because of the other patch "Add test for image palette functions."
Could you have a look?
-- Cheers,
Paul.
-- Vincent Povirk
On 12/15/2009 05:19 PM, Vincent Povirk wrote:
It seems the check for palettes larger than 256 was an improvement in windows vista. I guess the test can be removed (or changed to Ok||InvalidParameter), but what does this mean for the Wine implementation?
Your talking about that second failure (line 1058). That test failure doesn't seem to be OS-version specific but rather gdiplus version (.NET version?) specific. There are some XP and W2K3 boxes that don't show this failure. -- Cheers, Paul.
On Tue, Dec 15, 2009 at 12:18 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
Your talking about that second failure (line 1058). That test failure doesn't seem to be OS-version specific but rather gdiplus version (.NET version?) specific.
There are some XP and W2K3 boxes that don't show this failure.
But which way should Wine's gdiplus behave? Should it fail in this case (corresponding to the newer gdiplus version, probably), or succeed? -- Vincent Povirk
On 12/15/2009 08:00 PM, Vincent Povirk wrote:
On Tue, Dec 15, 2009 at 12:18 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
Your talking about that second failure (line 1058). That test failure doesn't seem to be OS-version specific but rather gdiplus version (.NET version?) specific.
There are some XP and W2K3 boxes that don't show this failure.
But which way should Wine's gdiplus behave? Should it fail in this case (corresponding to the newer gdiplus version, probably), or succeed?
I think that Wine should follow the latest and greatest. So it should be InvalidParameter. So we could add a broken(Ok) of some sort to indicate that we want to follow the new behavior. Does that make sense? -- Cheers, Paul.
On 12/15/2009 11:40 AM, Paul Vriens wrote:
On 12/13/2009 12:59 AM, Vincent Povirk wrote:
Hi Vincent,
It appears that this one introduced a test failure:
http://test.winehq.org/data/tests/gdiplus:image.html
One of the tests that fails now (line 533) was there for a long time it's just that you've added some stuff before that.
The other one (line 1058) is because of the other patch "Add test for image palette functions."
Could you have a look?
So there is one out of the way now. The one left only seems to effect XP and W2K3 (failure on line 533). If I skip this: if (stat == Ok) { /* test whether writing to the bitmap affects the original */ stat = GdipBitmapSetPixel(gpbm, 0, 0, 0xffffffff); expect(Ok, stat); expect(0, bits[0]); GdipDisposeImage((GpImage*)gpbm); } it works fine again. If I only skip the GdipBitmapSetPixel things are fine as well. Any idea? -- Cheers, Paul.
participants (2)
-
Paul Vriens -
Vincent Povirk