Re: [PATCH 1/3] d3dx9_36: Implement ID3DXFileDataImpl_Lock and ID3DXFileDataImpl_Unlock.

[Rico Schüller]

On 11.01.2013 09:40, Christian Costa wrote:
> static HRESULT WINAPI ID3DXFileDataImpl_Unlock(ID3DXFileData *iface)
>   {
> -    FIXME("(%p)->(): stub\n", iface);
> +    TRACE("(%p)->()\n", iface);
>
> -    return E_NOTIMPL;
> +    /* Nothing to do */
> +
> +    return S_OK;
>   }

Hi Christian,

I stumble over MSDN, it says in Remarks on 
http://msdn.microsoft.com/de-de/library/windows/desktop/bb205846%28v=vs.85%2... 
... from that sentence I'd think that you have to do some lock count. A 
test would probably be nice. Though, msdn has a bool as return value for 
the unlock function but in the header it's a HRESULT... Is msdn wrong here?

Cheers
Rico

[PATCH 1/3] d3dx9_36: Implement ID3DXFileDataImpl_Lock and ID3DXFileDataImpl_Unlock.

[Christian Costa]

2013/1/11 Rico Schüller <kgbricola(a)web.de>
> On 11.01.2013 09:40, Christian Costa wrote:
> > static HRESULT WINAPI ID3DXFileDataImpl_Unlock(**ID3DXFileData *iface)
> >   {
> > -    FIXME("(%p)->(): stub\n", iface);
> > +    TRACE("(%p)->()\n", iface);
> >
> > -    return E_NOTIMPL;
> > +    /* Nothing to do */
> > +
> > +    return S_OK;
> >   }
>
> Hi Christian,
>
> I stumble over MSDN, it says in Remarks on http://msdn.microsoft.com/de-**
> de/library/windows/desktop/**bb205846%28v=vs.85%29.aspx<http://msdn.microsoft.com/de-de/library/windows/desktop/bb205846%28v=vs.85%29.aspx>... from that sentence I'd think that you have to do some lock count. A
> test would probably be nice. Though, msdn has a bool as return value for
> the unlock function but in the header it's a HRESULT... Is msdn wrong here?
>
> Cheers
> Rico

Hi Rico,

Ok. Thanks. I missed that part. I will take a look.

Patch 2 & 3 of the serie are independant.

Bye