Re: [PATCH 1/4] shell32: Implement erasing and restoring items from the trash
30 Jun
2011
30 Jun
'11
11:37 a.m.
Hi Jay, +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl){ Nit: the brace should be on its own line. +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; +HRESULT TRASH_EraseItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; These two functions are never called in this patch, so you're introducing dead code. That's not allowed. Introduce the functions in the patch that uses them, please. If the resulting patch is too large, you must split it another way. --Juan
5369
Age (days ago)
5369
Last active (days ago)
0 comments
1 participants
participants (1)
-
Juan Lang