Re: d3dcompiler_43: Define BWRITER_SM1_VS and BWRITER_SM1_PS as unsigned constants.

[Józef Kucia]

Hi Gerald,

On Sun, Aug 9, 2015 at 1:47 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote:
> -#define BWRITER_SM1_VS  0xfffe
> -#define BWRITER_SM1_PS  0xffff
> +#define BWRITER_SM1_VS  0xFFFEu
> +#define BWRITER_SM1_PS  0xFFFFu

Lowercase hex literals are preferred in D3D code.

d3dcompiler_43: Define BWRITER_SM1_VS and BWRITER_SM1_PS as unsigned constants.

[Gerald Pfeifer]

On Sun, 9 Aug 2015, Józef Kucia wrote:
> > -#define BWRITER_SM1_VS  0xfffe
> > -#define BWRITER_SM1_PS  0xffff
> > +#define BWRITER_SM1_VS  0xFFFEu
> > +#define BWRITER_SM1_PS  0xFFFFu
> > Lowercase hex literals are preferred in D3D code.

I see.  (I figured that something like 0xFFFEu is easier to
read than 0xfffeu.)

Updated patch below.

Thanks,
Gerald


diff --git a/dlls/d3dcompiler_43/d3dcompiler_private.h b/dlls/d3dcompiler_43/d3dcompiler_private.h
index 2fafa94..1eea0d2 100644
--- a/dlls/d3dcompiler_43/d3dcompiler_private.h
+++ b/dlls/d3dcompiler_43/d3dcompiler_private.h
@@ -532,8 +532,8 @@ enum bwritershader_param_srcmod_type
     BWRITERSPSM_NOT,
 };
 
-#define BWRITER_SM1_VS  0xfffe
-#define BWRITER_SM1_PS  0xffff
+#define BWRITER_SM1_VS  0xfffeu
+#define BWRITER_SM1_PS  0xffffu
 
 #define BWRITERPS_VERSION(major, minor) ((BWRITER_SM1_PS << 16) | ((major) << 8) | (minor))
 #define BWRITERVS_VERSION(major, minor) ((BWRITER_SM1_VS << 16) | ((major) << 8) | (minor))