Re: [31/44] richedit: Set error codes and stop parsing for some rtf syntax errors.

[Rob Shearman]

Dylan Smith wrote:
> +      if (!inStream.editstream->dwError && parser.stackTop > 0)
> +        inStream.editstream->dwError = -2147024858;

This should be HRESULT_FROM_WIN32(ERROR_HANDLE_EOF).

-- 
Rob Shearman

[31/44] richedit: Set error codes and stop parsing for some rtf syntax errors.

[Dylan Smith]

Thanks, I didn't know where that constant was coming from.

I am attaching the updated patch.  The same description applies to it:

Checks were added for hexidecimal values that did not have valid
characters, and for EOF received before the final closing brace of the
rich text stream.  The error values were tested on richedit versions 1,
2, 3 & 4.1, and they were all the same for these cases.
---
 dlls/riched20/editor.c |    7 +++++--
 dlls/riched20/reader.c |    8 +++++---
 2 files changed, 10 insertions(+), 5 deletions(-)

On Wed, Jun 18, 2008 at 2:41 AM, Rob Shearman <robertshearman(a)gmail.com>
wrote:
> Dylan Smith wrote:
> > +      if (!inStream.editstream->dwError && parser.stackTop > 0)
> > +        inStream.editstream->dwError = -2147024858;
>
> This should be HRESULT_FROM_WIN32(ERROR_HANDLE_EOF).
>
> --
> Rob Shearman