[PATCH] mshtml: Fix use after free in use_gecko_script (Coverity)

29 Dec 2021

Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com>
---
 dlls/mshtml/script.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/script.c b/dlls/mshtml/script.c
index 28e07a50c8e..2a0d86c9f76 100644
--- a/dlls/mshtml/script.c
+++ b/dlls/mshtml/script.c
@@ -1716,12 +1716,13 @@ static BOOL use_gecko_script(IUri *uri)
         return FALSE;
 
     hres = IInternetSecurityManager_MapUrlToZone(get_security_manager(), display_uri, &zone, 0);
-    SysFreeString(display_uri);
     if(FAILED(hres)) {
         WARN("Could not map %s to zone: %08x\n", debugstr_w(display_uri), hres);
+        SysFreeString(display_uri);
         return TRUE;
     }
 
+    SysFreeString(display_uri);
     TRACE("zone %d\n", zone);
     return zone == URLZONE_UNTRUSTED;
 }
-- 
2.34.1

    

Alex Henrie