[PATCH] wininet/tests: Fix memory leaks.
Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> --- dlls/wininet/tests/internet.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c index 7889e40ea8..03760b6f34 100644 --- a/dlls/wininet/tests/internet.c +++ b/dlls/wininet/tests/internet.c @@ -1256,6 +1256,8 @@ static void test_Option_PerConnectionOption(void) ret = InternetQueryOptionW(NULL, INTERNET_OPTION_PER_CONNECTION_OPTION, &list, &size); ok(ret == TRUE, "InternetQueryOption should've succeeded\n"); + + HeapFree(GetProcessHeap(), 0, list.pOptions); orig_settings = list.pOptions; /* set the global IE proxy server */ @@ -1384,6 +1386,8 @@ static void test_Option_PerConnectionOptionA(void) ret = InternetQueryOptionA(NULL, INTERNET_OPTION_PER_CONNECTION_OPTION, &list, &size); ok(ret == TRUE, "InternetQueryOption should've succeeded\n"); + + HeapFree(GetProcessHeap(), 0, list.pOptions); orig_settings = list.pOptions; /* set the global IE proxy server */ -- 2.21.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=56171 Your paranoid android. === wxppro (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded 0940:internet: unhandled exception c0000005 at 7C910CCE === w2003std (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded 01e8:internet: unhandled exception c0000005 at 7C82C614 === wvistau64 (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === wvistau64_zh_CN (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === wvistau64_fr (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === wvistau64_he (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w2008s64 (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w7u (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w7pro64 (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w8 (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w8adm (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w864 (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w1064v1507 (32 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded internet.c:1464: Test failed: InternetSetOption should've succeeded === w1064v1809 (32 bit report) === wininet: internet.c:1464: Test failed: InternetSetOption should've succeeded === wvistau64 (64 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded Report errors: wininet:internet crashed (c0000374) === w2008s64 (64 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded Report errors: wininet:internet crashed (c0000374) === w7pro64 (64 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded Report errors: wininet:internet crashed (c0000374) === w864 (64 bit report) === Report errors: wininet:internet crashed (c0000374) === w1064v1507 (64 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded Report errors: wininet:internet crashed (c0000374) === w1064v1809 (64 bit report) === wininet: internet.c:1366: Test failed: InternetSetOption should've succeeded Report errors: wininet:internet crashed (c0000374)
participants (2)
-
Andrey Gusev -
Marvin