Re: [PATCH] oleaut32: Improve ITypeLib::FindName

[Nikolay Sivov]

On 1/17/2014 21:40, Andrew Eikum wrote:
> ---
>   dlls/oleaut32/tests/typelib.c | 99 +++++++++++++++++++++++++++++++++++++++++--
>   dlls/oleaut32/typelib.c       | 19 ++++++---
>   2 files changed, 107 insertions(+), 11 deletions(-)
> +
>           for(fdc = 0; fdc < pTInfo->cFuncs; ++fdc) {
>               TLBFuncDesc *func = &pTInfo->funcdescs[fdc];
>               int pc;
>
> -            if(!TLB_str_memcmp(name, func->Name, len)) goto ITypeLib2_fnFindName_exit;
> -            for(pc = 0; pc < func->funcdesc.cParams; pc++) {
> -                if(!TLB_str_memcmp(name, func->pParamDesc[pc].Name, len))
> -                    goto ITypeLib2_fnFindName_exit;
> +            if(!TLB_str_memcmp(name, func->Name, len)) {
> +                memid[count] = func->funcdesc.memid;
> +                goto ITypeLib2_fnFindName_exit;
>               }
>           }

Minor problem, 'pc' should be removed.